[17.0][FIX] hr_employee_second_lastname: removed useless mapped address_home_id #1370
Conversation
|
Hi @luisg123v, |
DorianMAG
force-pushed
the
17.0-fix-hr_employee_second_lastname
branch
from
3364a66
to
93429c5
Compare
Hi @luisg123v Regards |
|
If the partner_firstname module is installed, |
|
Hi @luisg123v , any chance to have a new review here ? |
There was a problem hiding this comment.
Hi,
The commit message doesn't conform guidelines yet.
Current commit message is:
[17.0][FIX] hr_employee_firstname: removal of the mapped method which became useless with the address_home_id field, this no longer exists in v17 and replaced by a non-relational field (field.char) named private_street
It needs the following changes to conform guidelines:
- Remove version
- It should be a short title, followed by a blank line, followed by a message
- Lines should be wrapped to 72 characters
| @@ -75,7 +75,6 @@ def _prepare_vals_on_write_firstname_lastname(self, vals): | |||
| def _update_partner_firstname(self): | |||
| for employee in self: | |||
| partners = employee.mapped("user_id.partner_id") | |||
| partners |= employee.mapped("address_home_id") | |||
There was a problem hiding this comment.
Shouldn't this be replaced by address_id instead?
CC @xmglord
There was a problem hiding this comment.
No it should be replaced with work_contact_id since address_home_id was split in multiple fields. I took this from Odoo.
There was a problem hiding this comment.
Thank you for your feedback, I will fix this quickly.
Regards
There was a problem hiding this comment.
It's done, but the tests are now failing. Should I do something else?
DorianMAG
force-pushed
the
17.0-fix-hr_employee_second_lastname
branch
2 times, most recently
from
34e8799
to
921afce
Compare
…e_id Remove useless mapped. The source code has changed in OCB/OdooSA. The relational field no longer exists on the address in V17. https://github.com/OCA/OCB/blob/3afef8250c829406a8fd227a6bd9f71c4f80ff29/addons/hr/models/hr_employee.py#L49
DorianMAG
force-pushed
the
17.0-fix-hr_employee_second_lastname
branch
from
921afce
to
b6c9dfd
Compare
Done |
Remove useless mapped.
The source code has changed in OCB/OdooSA.
The relational field no longer exists on the address in V17.
https://github.com/OCA/OCB/blob/3afef8250c829406a8fd227a6bd9f71c4f80ff29/addons/hr/models/hr_employee.py#L49