Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] hr_employee_document: ir.rule _compute_domain method #1323

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[FIX] hr_employee_document: ir.rule _compute_domain method #1323

merged 1 commit into from
Nov 30, 2023

Conversation

marcelsavegnago
Copy link
Member

kaynnan
kaynnan approved these changes Nov 30, 2023
View reviewed changes
Copy link

@kaynnan kaynnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (CODE REVIEW)

douglascstd
douglascstd approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@douglascstd douglascstd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[FUNCIONAL REVIEW] APPROVED

image

image

pedrobaeza
pedrobaeza approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-1323-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e2e21d7 into OCA:14.0 Nov 30, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fbfc96d. Thanks a lot for contributing to OCA. ❤️

@marcelsavegnago marcelsavegnago deleted the 14.0-hr_employee_document-fix_compute_domain-method branch November 30, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaynnan kaynnan kaynnan approved these changes

@douglascstd douglascstd douglascstd approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@rvalyi rvalyi rvalyi approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marcelsavegnago @OCA-git-bot @rvalyi @pedrobaeza @douglascstd @kaynnan