Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP]helpdesk_mgmt: better attachment support #642

Merged
merged 3 commits into from
Nov 29, 2024
Merged

[16.0][IMP]helpdesk_mgmt: better attachment support #642

merged 3 commits into from
Nov 29, 2024
+62 −3

Conversation

PicchiSeba
Copy link

Forward ports #463 which itself forward-ported the commit 656c2d9 from 12.0 to 14.0

@PicchiSeba PicchiSeba changed the title [16.0][IMP]helpdesk_mgmt: better attch support [16.0][IMP]helpdesk_mgmt: better attachment support Oct 21, 2024
@PicchiSeba PicchiSeba force-pushed the 16.0-better-attch-support branch from d629dd8 to e3da5e2 Compare October 21, 2024 10:42
flotho
flotho approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
already tested on production

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 23, 2024
eLBati and others added 3 commits November 25, 2024 09:21
@eLBati @PicchiSeba
[IMP] helpdesk_mgmt: Show attachments on portal's ticket view
0a5d0d8 
Forward port of 656c2d9

Note that the commit fc3905e (allow portal users to write tickets) has not been forward ported as it is not necessary
@ypapouin @PicchiSeba
[IMP] helpdesk_mgmt: Generate access_token for all attachments adde…
36f0560 
…d on ticket submit

Otherwise they stay "private" and are not displayed on the portal.
@ypapouin @PicchiSeba
[IMP] helpdesk_mgmt: Test submit with attachments
46b8a97
@PicchiSeba PicchiSeba force-pushed the 16.0-better-attch-support branch from e3da5e2 to 46b8a97 Compare November 25, 2024 08:23
aleuffre
aleuffre approved these changes Nov 26, 2024
View reviewed changes
Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza
pedrobaeza approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-642-by-pedrobaeza-bump-minor, awaiting test results.

@pedrobaeza
Copy link
Member

To fw-port to upper versions.

@OCA-git-bot OCA-git-bot merged commit f4c7249 into OCA:16.0 Nov 29, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 64cf97c. Thanks a lot for contributing to OCA. ❤️

@PicchiSeba PicchiSeba deleted the 16.0-better-attch-support branch November 29, 2024 13:22
@PicchiSeba PicchiSeba mentioned this pull request Nov 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleuffre aleuffre aleuffre approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@flotho flotho flotho approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@PicchiSeba @OCA-git-bot @pedrobaeza @flotho @aleuffre @eLBati @ypapouin