[16.0][ADD] base_wamas, base_wamas_ubl: Add new modules to handle the WAMAS document #856

tuantrantg · 2023-11-07T10:28:28Z

No description provided.

simahawk

early comments

simahawk · 2023-11-17T09:17:10Z

.pre-commit-config.yaml

@@ -8,6 +8,8 @@ exclude: |
  .svg$|/tests/([^/]+/)?cassettes/|^.copier-answers.yml$|^.github/|
  # Maybe reactivate this when all README files include prettier ignore tags?
  ^README\.md$|
+  # Ignore the text files


if needed this should be added to the template

simahawk · 2023-11-20T06:17:01Z

base_wamas/models/wamas_document_default_field.py

+from odoo import models
+
+
+class WamasDocumentDefaultField(models.Model):


Please, add docstrings on all classes and methods to explain what they represent/do

simahawk · 2023-11-20T06:25:06Z

base_wamas/models/wamas_document_field.py

+        if self.ttype == "str":
+            res = self._get_string(value)
+        elif self.ttype == "int":
+            res = self._get_int(value)
+        elif self.ttype == "float":
+            res = self._get_float(value)
+        elif self.ttype == "date":
+            res = self._get_date(value)
+        elif self.ttype == "datetime":
+            res = self._get_datetime(value)
+        elif self.ttype == "bool":
+            res = self._get_bool(value)


Suggested change

if self.ttype == "str":

res = self._get_string(value)

elif self.ttype == "int":

res = self._get_int(value)

elif self.ttype == "float":

res = self._get_float(value)

elif self.ttype == "date":

res = self._get_date(value)

elif self.ttype == "datetime":

res = self._get_datetime(value)

elif self.ttype == "bool":

res = self._get_bool(value)

getters = dict(

str=self._get_string,

int=self._get_int

[....]

)

return getters[self.ttype](value)

Those methods should be renamed like... _get_value_from_string__[$ttype]

An alternative to the dict of getters is:

handler = getattr(self, f"_get_value_from_string__{self.ttype}`) return handler(value)

simahawk · 2023-11-20T06:25:55Z

base_wamas/models/wamas_document_field.py

+        res = value.strip()
+
+        ICP = self.env["ir.config_parameter"]
+        lst_false = safe_eval(ICP.get_param("wamas_document_list_false_value", ["f"]))


do we really need params for this?

it's needed, so that user can configure what value they want to get

simahawk · 2023-11-20T06:26:39Z

base_wamas/models/wamas_document_element.py

+
+        res = False
+
+        if result_type == "list_tuple":


What is the purpose of having a different result?
IMO it would be better to have 2 methods...

What is the purpose of having a different result?

the list_tuple: list is each line of UBL document and each tuple (in list) is each element in the line -> one list_tuple related to one line -> it's so generic to use for any purpose

the ordered_dict: ordered_dict is a line and each item of ordered_dict is each element in the line -> I use this to build the ordered dict structure for converting wamas -> ubl in base_wamas_ubl

IMO it would be better to have 2 methods...

I agree, it should be better if have 2 methods, I'll split it into 2 methods

simahawk · 2023-11-20T06:28:20Z

base_wamas/models/wamas_document_field.py

+    name = fields.Char(required=True)
+    code = fields.Char(required=True)
+    ttype = fields.Selection(FIELD_TYPES, "Type", required=True)
+    len_field = fields.Integer("Length", required=True)


Can you add some help ?

simahawk · 2023-11-20T06:30:26Z

base_wamas/tests/test_base_wamas.py

+from odoo.tools import file_open, file_path
+
+
+class TestBaseWamas(TransactionCase):


It would be nice to have full test coverage, possibly via unit tests

sure, I'll do it, if I finish the other main functions

simahawk · 2023-11-20T06:31:08Z

base_wamas/readme/DESCRIPTION.rst

+* WAMAS Document Element, to define elements in WAMAS document, such as: WEAK, WEAP...
+* WAMAS Document Field, to define fields that WAMAS elment has, there are a lot of fields in a WAMAS element.
+* WAMAS Document Default Field, to define default fields of WAMAS document has.
+* WAMAS Document Default Field Template, to define the template of default fields of the elements.


pls add a CONFIGURE.rst

simahawk · 2023-11-20T06:35:45Z

base_wamas_ubl/data/ir_actions_server_data.xml

+<?xml version="1.0" encoding="utf-8" ?>
+<odoo noupdate="0">
+
+    <record id="ias_get_ubl_version" model="ir.actions.server">


I don't get why you need server actions... 🤔

because UBL has a lot of templates and we cannot add hard-coding functions, user can add functions that they need for their UBL documents, so I use ir.actions.server for this purpose.

it's may not right to use ir.actions.server like this, but user can control their document actively

… document

tuantrantg marked this pull request as draft November 7, 2023 10:28

tuantrantg force-pushed the 16.0-add-base_wamas branch from f7d564b to 66eca49 Compare November 7, 2023 10:45

tuantrantg marked this pull request as ready for review November 7, 2023 11:00

tuantrantg force-pushed the 16.0-add-base_wamas branch 3 times, most recently from 51731c5 to 65dced8 Compare November 10, 2023 07:09

tuantrantg marked this pull request as draft November 10, 2023 07:32

tuantrantg force-pushed the 16.0-add-base_wamas branch from 65dced8 to 7e6eed8 Compare November 10, 2023 07:46

tuantrantg changed the title ~~[16.0][ADD] base_wamas: Add new module to handle the WAMAS document~~ [16.0][ADD] base_wamas, base_wamas_ubl: Add new modules to handle the WAMAS document Nov 10, 2023

tuantrantg force-pushed the 16.0-add-base_wamas branch 7 times, most recently from ccbc5ea to e0eb45e Compare November 15, 2023 10:19

simahawk reviewed Nov 20, 2023

View reviewed changes

[ADD] base_wamas, base_wamas_ubl: Add new modules to handle the WAMAS…

4787b0c

… document

tuantrantg force-pushed the 16.0-add-base_wamas branch from e0eb45e to 4787b0c Compare November 20, 2023 08:05

tuantrantg closed this Nov 27, 2023

tuantrantg mentioned this pull request Nov 27, 2023

[16.0][ADD] base_wamas_ubl: Add new module to convert WAMAS files to UBL files and vice versa #875

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][ADD] base_wamas, base_wamas_ubl: Add new modules to handle the WAMAS document #856

[16.0][ADD] base_wamas, base_wamas_ubl: Add new modules to handle the WAMAS document #856

tuantrantg commented Nov 7, 2023

simahawk left a comment

simahawk Nov 17, 2023

simahawk Nov 20, 2023

simahawk Nov 20, 2023

simahawk Nov 20, 2023

tuantrantg Nov 20, 2023

simahawk Nov 20, 2023

tuantrantg Nov 20, 2023 •

edited

Loading

simahawk Nov 20, 2023

simahawk Nov 20, 2023

tuantrantg Nov 20, 2023

simahawk Nov 20, 2023

simahawk Nov 20, 2023

tuantrantg Nov 20, 2023

		from odoo import models


		class WamasDocumentDefaultField(models.Model):

		from odoo.tools import file_open, file_path


		class TestBaseWamas(TransactionCase):

[16.0][ADD] base_wamas, base_wamas_ubl: Add new modules to handle the WAMAS document #856

[16.0][ADD] base_wamas, base_wamas_ubl: Add new modules to handle the WAMAS document #856

Conversation

tuantrantg commented Nov 7, 2023

simahawk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tuantrantg Nov 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tuantrantg Nov 20, 2023 •

edited

Loading