[16.0][IMP] sale_order_import: Add confirm_order flag to wizard #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuocDuong1306
changed the title
QuocDuong1306
force-pushed
the
16.0-imp-sale_order_import
branch
from
d69cdeb to
890dcf7
Compare
simahawk
requested changes
Oct 25, 2023
There was a problem hiding this comment.
Cool, thank you!
Few remarks:
- would be nice to have a test
- please rewrite the commit msg
[IMP] sale_order_import: add confirm_order flag to wizard
When the flag is enabled, the order will be automatically confirmed.
Mostly used when the wizard is used as a tool to import orders.
When the flag is enabled, the order will be automatically confirmed. Mostly used when the wizard is used as a tool to import orders.
QuocDuong1306
force-pushed
the
16.0-imp-sale_order_import
branch
from
890dcf7 to
686723f
Compare
QuocDuong1306
changed the title
|
Thank @simahawk , I updated |
simahawk
approved these changes
Oct 25, 2023
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at f2801ed. Thanks a lot for contributing to OCA. ❤️ |
|
FTR while working on #1090 I've spotted a bug here. I'll fwd port from there when merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the flag is enabled, the order will be automatically confirmed.
Mostly used when the wizard is used as a tool to import orders.