-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] edi_voxel_sale_order_import: Migration to version 15.0 #678
[15.0][MIG] edi_voxel_sale_order_import: Migration to version 15.0 #678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration commit LGTM
b154b36
to
0a74aa0
Compare
Rebase done |
0a74aa0
to
4a692b0
Compare
@sergio-teruel as this depends on |
/ocabot migration edi_voxel_sale_order_import |
cae2ce5
to
c8ead5b
Compare
@simahawk why a module with a name |
c8ead5b
to
d7e03d2
Compare
Please check CI |
It has been ripped out of business document import in 14 a long time ago and I didn't want to move it to minimize the impact on everybody else. I'm not against moving it (maybe to server-tools). |
Well, that one is making the CI to fail. Please check at least that. And with pip, it's supposed that the OCA repo where it's hosted is not important. |
Not for CI, or for me. Is for the ones not relying on it 😉 Et voilá #811 |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@sergio-teruel rebase to test |
This module allows users to import automatically sale orders from Voxel
[FIX] edi_voxel_sale_order_import: Protect views with groups [FIX+IMP] edi_voxel_sale_order_import: Fine-tuning on the module [FIX] edi_voxel_sale_order_import: Propagate company [FIX] edi_voxel_sale_order_import: Fix test [FIX+IMP] edi_voxel_sale_order_import: Raise if product not found + company UI reorder + play onchanges [FIX] edi_voxel_sale_order_import: Add ref to customers parser [FIX] edi_voxel_sale_order_import: Simulate a real order for getting line vals [FIX] edi_voxel_sale_order_import: Better SO creation Previous one was a hack.
[FIX] edi_voxel_sale_order_import: Ref goes to client_order_ref, not to origin [FIX] edi_voxel_sale_order_import: Fix test
After assigning the partner, we need to populate expected values for such partner, using `play_onchanges`.
If we set initially a pricelist, when playing onchanges on the partner, the pricelist will remain the same, no matter the pricelist associated to the partner. As we want to use the partner's pricelist, we remove the initial pricelist assignation.
Use the same technique for qualifying the product (but reversed) than used on pickings: - See if there's a product with the reference. - If not, check for a customerinfo record with such code, first on the order partner, and if not found yet, on the commercial entity. Note that here the CustomerSKU/SupplierSKU seems to be swapped from their normal use in pickings/invoices according to empirical samples. TT30469 Co-Authored-By: Pedro M. Baeza <[email protected]>
d7e03d2
to
bf15e4f
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
On my way to merge this fine PR! |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-678-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
bf15e4f
to
455556e
Compare
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 1c9f8d0. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT36456
ping @carlosdauden @CarlosRoca13
depends on: