Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] website_sale_require_login: Migration to 16.0 #935

Open
wants to merge 27 commits into
base: 16.0
Choose a base branch
from

Conversation

carolina-domatix
Copy link

No description provided.

yajo and others added 27 commits June 11, 2024 11:56
Example of module which requires such refactoring:

https://github.com/it-projects-llc/website-addons/tree/10.0/website_sale_checkout_store

[FIX] condition to show normal checkout button was wrong in website_sale_suggest_create_account
I was equal to

(user_authenticated or not signup_allowed and can_checkout)

while it has to be

(user_authenticated or not signup_allowed) and can_checkout
This test was expecting sign up to be disabled because `auth_signup` is not in its module graph, but since that addon is autoinstallable, it could be installed without our knowledge.

Just make sure signup is disabled before running the public user test, to make it unitary.

Also, moved to at-install mode, since the post-install one adds no value.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: e-commerce-15.0/e-commerce-15.0-website_sale_require_login
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_require_login/
@carolina-domatix carolina-domatix force-pushed the 16.0-mig-website_sale_require_login branch from 7115617 to 18dcd95 Compare June 11, 2024 11:28
Copy link
Member

@victor-champonnois victor-champonnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test OK
Don't understand why the CI test doesn't work though.

Copy link

@remytms remytms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But the CI is red and no logs are provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.