Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] product_template_multi_link #920

Open
wants to merge 52 commits into
base: 17.0
Choose a base branch
from

Conversation

David-Luis-Mora
Copy link

No description provided.

legalsylvain and others added 30 commits May 2, 2024 12:18
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: e-commerce-13.0/e-commerce-13.0-product_template_multi_link
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-product_template_multi_link/
Although the tree view is editable, when creating link with a filter
applied it is the form view that is displayed. With none defined it
looks a bit messy.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: e-commerce-13.0/e-commerce-13.0-product_template_multi_link
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-product_template_multi_link/
Currently translated at 21.6% (8 of 37 strings)

Translation: e-commerce-13.0/e-commerce-13.0-product_template_multi_link
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-product_template_multi_link/vi_VN/
Currently translated at 54.0% (20 of 37 strings)

Translation: e-commerce-13.0/e-commerce-13.0-product_template_multi_link
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-product_template_multi_link/nl/
Currently translated at 100.0% (37 of 37 strings)

Translation: e-commerce-14.0/e-commerce-14.0-product_template_multi_link
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-product_template_multi_link/es_AR/
rousseldenis and others added 15 commits May 2, 2024 12:18
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: e-commerce-14.0/e-commerce-14.0-product_template_multi_link
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-product_template_multi_link/
Currently translated at 100.0% (52 of 52 strings)

Translation: e-commerce-14.0/e-commerce-14.0-product_template_multi_link
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-product_template_multi_link/es_AR/
Currently translated at 17.3% (9 of 52 strings)

Translation: e-commerce-14.0/e-commerce-14.0-product_template_multi_link
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-product_template_multi_link/it/
Currently translated at 100.0% (52 of 52 strings)

Translation: e-commerce-16.0/e-commerce-16.0-product_template_multi_link
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-product_template_multi_link/es/
Currently translated at 17.3% (9 of 52 strings)

Translation: e-commerce-16.0/e-commerce-16.0-product_template_multi_link
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-product_template_multi_link/it/
@David-Luis-Mora David-Luis-Mora force-pushed the 17.0-mig-product_template_multi_link branch from 2b3ac77 to 3e0ff67 Compare May 2, 2024 14:07
@David-Luis-Mora David-Luis-Mora mentioned this pull request May 2, 2024
27 tasks
Comment on lines 14 to 16
<field
name="inverse_name"
required="1"
attrs="{'readonly': [('is_symmetric', '=', True)]}"
/>
<field name="inverse_name" required="1" invisible="is_symmetric" />
<field name="code" />
<field
name="inverse_code"
attrs="{'readonly': [('is_symmetric', '=', True)]}"
/>
<field name="inverse_code" invisible="is_symmetric" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@David-Luis-Mora You changed a readonly to invisible instead.

lambda l: l.right_product_tmpl_id == self.product2
lambda r: r.right_product_tmpl_id == self.product2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@David-Luis-Mora Was this change made for any specific reason?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because when I made the pre-commit it was giving me an error, so I had to make that change.

@David-Luis-Mora David-Luis-Mora force-pushed the 17.0-mig-product_template_multi_link branch from 3e0ff67 to 05c2332 Compare May 6, 2024 08:27
Copy link

github-actions bot commented Sep 8, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 8, 2024
Copy link

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG overall

"""
result = super().default_get(fields_list)
ctx = self.env.context
active_ids = ctx.get("active_ids", ctx.get("active_id", []))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we favor id instead of active_id here as well?
Although is not clear what to do w/ active_ids...

@simahawk simahawk removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 9, 2024
@simahawk
Copy link

simahawk commented Sep 9, 2024

/ocabot migration product_template_multi_link

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.