Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0 Add support for multi company #212

Open
wants to merge 7 commits into
base: 8.0
Choose a base branch
from

Conversation

lmignon
Copy link

@lmignon lmignon commented May 20, 2016

The goal of this PR is to add the ability to support multi companies with the connector Magento. This PR follows the same idea as the one expressed in the blueprint of @guewen https://blueprints.launchpad.net/openerp-connector-magento/+spec/import-multi-company multi company imp
At this stage multi company is supported for

  • sale.order: the sale.order are created by company
  • res.partner: the re.partner are created without company if the backend is configured in multi company mode.

In our case, we don't need to import the products from magento, therefore, nothing has been modified to support the mutli company on products.

  • product.product

By default nothing is provided by magento to support different warehouses by website/store/storeview. In our case we use a specific addon for magento (from smile) and we have developped a specialized odoo addon to export the product qty by warehouse.

  • stock???

@StefanRijnhart
Copy link
Member

Hi @lmignon, @laetitia-gangloff, is this perhaps ready for review?

@lmignon
Copy link
Author

lmignon commented Jul 18, 2016

@StefanRijnhart This PR provides a partial solution to support multi companies with magento. This code is used in production. IMO it's ready for review...

@StefanRijnhart
Copy link
Member

We have been testing this (we can live with the limitations). 👍 and thanks!

@StefanRijnhart StefanRijnhart added this to the 8.0 milestone Jul 18, 2016
string='Specific warehouse',
help='If specified, this warehouse will be used to load fill the '
'field warehouse (and company) on the sale order created by the '
'connector.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working in my setup. We get another warehouse from the same company. In fact, I cannot seem to find any place (in this patch or elsewhere) where the Magento warehouse setting is used to assign a warehouse to the sale orders imported from Magento. The Magento documentation does not even claim that the warehouse setting is used as such, but says the warehouse is used to gather the available product quantities instead (http://odoo-magento-connector.com/howto/configure_warehouse.html). Can you confirm that this setting is actually ignored for sale orders created from the Magento import?

@lmignon
Copy link
Author

lmignon commented Oct 12, 2016

@StefanRijnhart Indeed, we only use this information to compute the stock for a specific warehouse into magento (custom module in magento)

@StefanRijnhart
Copy link
Member

@lmignon How about acsone#1?

…_company

[ADD] Select warehouse for sale order
Copy link

@susport susport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please to corrrect de travis error.

@StefanRijnhart
Copy link
Member

@susport those errors are unrelated to this change and can be fixed separately.

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been running this in production for months now.

@Cedric-Pigeon
Copy link

@guewen Can you consider this PR in your V10 migration ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants