Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][FIX] account_commission: redefine partner can cause issue #447

Merged
merged 1 commit into from
Aug 26, 2023
Merged

[15.0][FIX] account_commission: redefine partner can cause issue #447

merged 1 commit into from
Aug 26, 2023

Conversation

jguenat
Copy link
Member

@jguenat jguenat commented Aug 25, 2023

  • partner is already defined above
  • self can contain multiple records with different agents if overriding grouping criteria

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 15.0 milestone Aug 26, 2023
pedrobaeza
pedrobaeza reviewed Aug 26, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should instead put partner = settlement.agent_id, as the intention of this is to put the line in the agent's regional conf. As you say, if the grouping criteria is another, there can be several agents involved, each one with a different language.

@jguenat
Copy link
Member Author

jguenat commented Aug 26, 2023

I though of that but I found it strange to have potentially a different language per invoice line.
If it was intentional then let's keep it.

@jguenat jguenat force-pushed the 15.0-fix-account_commission branch from e9ddbf6 to 2ae4980 Compare August 26, 2023 08:41
pedrobaeza
pedrobaeza approved these changes Aug 26, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-447-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ddcb318 into OCA:15.0 Aug 26, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 700f3b7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jguenat @OCA-git-bot @pedrobaeza