[15.0][IMP] commission: multi-currency support

[jguenat]

Supersede #405

Improvements based on review in #405 are in a separate commit that will be fixed up later.

[OCA-git-bot]

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

[pedrobaeza]

Shouldn't we have in settlement lines both amount in company currency and in the original currency?

[jguenat]

If we need to settle the settlement with an invoice in the company currency it could be useful indeed.
We need to be careful about currency exchange rate. On the settlement line the rate from the source invoice date is used, then when we make the settlement invoice it will be another rate.
This could lead to confusion.

Maybe if we are able to choose the settlement invoice currency (original or company) then there is enough flexibility.

Next week I have a meeting with a customer that use commissions in different currency. I'll ask how they manage it actually. I guess it depends on the commission agreement.

[JordiMForgeFlow]

Hi @jguenat

Are there any plans to continue with this PR?

[jguenat]

Hi @JordiMForgeFlow ,

I've been using this module for a client and it seems to work like this but the real commission on foreign currency will be settled early 2024 and maybe I'll have some adjustment to do then.

But if you have time to review this we can already go forward.

[JordiMForgeFlow]

Hi @jguenat

Any chance the PR could be rebased?

[jguenat]

@JordiMForgeFlow I rebased but we can continue there #479 no problem

[JordiMForgeFlow]

Code + functional review LGTM!

[pedrobaeza]

/ocabot merge major

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-446-by-pedrobaeza-bump-major, awaiting test results.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[OCA-git-bot]

Congratulations, your PR was merged at 486bee7. Thanks a lot for contributing to OCA. ❤️