[IMP] sale_commission_product_criteria_discount: correct commission t…

…ype check
OCA · Aug 22, 2023 · e4a6d48 · e4a6d48
1 parent 2fe4eec
commit e4a6d48
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/sale_commission_product_criteria_discount/models/sale.py b/sale_commission_product_criteria_discount/models/sale.py
@@ -14,7 +14,7 @@ def _get_single_commission_amount(self, commission, subtotal, product, quantity)
         self.ensure_one()
         if product.commission_free or not commission:
             return 0.0
-        if commission.commission_type != "product":
+        if commission.commission_type in ["percentage", "fixed"]:
             return self._get_commission_amount(commission, subtotal, product, quantity)
         item_ids = self._get_commission_items(commission, product)
         if not item_ids:

diff --git a/sale_commission_product_criteria_domain/readme/DESCRIPTION.rst b/sale_commission_product_criteria_domain/readme/DESCRIPTION.rst
@@ -1,7 +1 @@
-This module allows to manage the following commission structure use case:
-
-Agent A receives commission 50 when selling product 1 to customer X
-
-Agent A receives commission 20 when selling product 1 to customer Y
-
-This behavior is integrated with both pricelist-like Commission Type structure (sale_commission_product_criteria) and commission by discount (sale_commission_product_criteria_discount)
+This module allows to limit applied commission items for specific groups.
diff --git a/...le_commission_product_criteria_domain/odoo/addons/sale_commission_product_criteria_domain b/...le_commission_product_criteria_domain/odoo/addons/sale_commission_product_criteria_domain
@@ -0,0 +1 @@
+../../../../sale_commission_product_criteria_domain
diff --git a/setup/sale_commission_product_criteria_domain/setup.py b/setup/sale_commission_product_criteria_domain/setup.py
@@ -0,0 +1,6 @@
+import setuptools
+
+setuptools.setup(
+    setup_requires=['setuptools-odoo'],
+    odoo_addon=True,
+)