[17.0][MIG] account_brand #193

RicardCForgeFlow · 2024-03-11T09:28:56Z

Migration to 17.0

GuillemCForgeFlow · 2024-03-11T11:20:27Z

account_brand/readme/USAGE.md

+1.  Go to Accounting \> Customers \> Invoices
+2.  Select or create an invoice
+3.  Enter the information and select the brand
+4.  Print the PDF report. It includes the information of the brand.


I don't see point 4 implemented. Is it?
Perhaps any of you can help me with that? 😄 @sbejaoui @RLeeOSI @osi-scampbell @max3903 @cubells @AmmarOfficewalaSerpentCS

@GuillemCForgeFlow
I think that point 4 is https://github.com/OCA/brand/pull/205/files

To use this module, you need to:

Go to Settings > Users & Companies > Brands

Add a new brand or select an existing one

Enter brand information and select the a layout

Go to any branded object abd print the PDF report. It includes the
information of the brand.

Can you rebase for merge it?

github-actions · 2024-07-14T12:43:46Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

was on OCA/partner-contact, switch to OCA/brand

…sale object

… state

[ADD] - add sbejaoui as maintainer [IMP] - move brand config section outside multi_company section [FIX] - add brand_use_level to fields_view_get fields

…er can't fill up analytic account on invoice lines

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: brand-16.0/brand-16.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-account_brand/

Currently translated at 86.3% (19 of 22 strings) Translation: brand-16.0/brand-16.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-account_brand/de/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: brand-16.0/brand-16.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-account_brand/

Currently translated at 72.7% (16 of 22 strings) Translation: brand-16.0/brand-16.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-account_brand/hr/

Currently translated at 100.0% (22 of 22 strings) Translation: brand-16.0/brand-16.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-account_brand/hr/

Currently translated at 100.0% (22 of 22 strings) Translation: brand-16.0/brand-16.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-account_brand/es/

Currently translated at 100.0% (22 of 22 strings) Translation: brand-16.0/brand-16.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-account_brand/es_AR/

FernandoRomera

LGTM

bosd

Functional review..
Left V16 right V17 runboat of this pr.
Something very important is missing 😉

account_brand/views/account_move_views.xml

GuillemCForgeFlow · 2024-11-06T11:24:24Z

@bosd guessing that's what you were mentioning, right?

bosd · 2024-11-06T12:05:51Z

@bosd guessing that's what you were mentioning, right?

Indeed, the brand field was not visible in the view. 😉

RicardCForgeFlow · 2024-11-06T12:21:18Z

Hi @bosd and @GuillemCForgeFlow.
Since the PR was made to now the original view of the account module has changed. Now you should be able to see the brand field.

Thank you very much for the help 😄

GuillemCForgeFlow · 2024-11-06T12:28:50Z

account_brand/models/res_partner_account_brand.py

+                ("internal_type", "=", "receivable"),
+                ("deprecated", "=", False),
+            ]
+        return {"domain": {"account_id": domain}}


This does not work in v17 anymore. Instead, you could create a computed field for which you'd assign a domain to be then used in the view

Good catch 🤾

GuillemCForgeFlow · 2024-11-06T12:38:36Z

account_brand/views/account_move_views.xml

+        <field name="model">account.move</field>
+        <field name="inherit_id" ref="account.view_move_form" />
+        <field name="arch" type="xml">
+            <field name="partner_shipping_id" position="before">


still can't see the field in the runboat 🤔 perhaps we'll need to analyze in more detail how to add it to the view.

Disregard this comment, I needed to activate the brand_use_level. we could perhaps make it more explicit in the documentation?

I needed to activate the brand_use_level. we could perhaps make it more explicit in the documentation?

Fell into the same trap. 😿 That would be a good improvement.

bosd · 2024-11-06T15:35:09Z

Thank you very much for the help

You owe me a 🍺 at the next oca days / oxp 😆

The field is there now 😉

GuillemCForgeFlow reviewed Mar 11, 2024

View reviewed changes

JasminSForgeFlow mentioned this pull request May 20, 2024

[17.0][MIG] sale_brand #200

Closed

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 14, 2024

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 28, 2024

osi-scampbell and others added 25 commits August 2, 2024 10:57

[ADD] account_brand (#568)

78ae391

[12.0][IMP] - dedicated model for partner brand in account_brand module

94efd03

Fix URL to OCA/brand

a2fa77e

was on OCA/partner-contact, switch to OCA/brand

[12.0][REF] - Use brand mixin in branded invoices definition

6536ced

[12.0][IMP] - Improve unit tests

da773a8

[12.0][IMP] - Improve readme

8fa3792

account_brand 12.0.2.1.0

8876d2b

[12.0][IMP] - Brand field is editable in draft state for invoice and …

c558aa9

…sale object

account_brand 12.0.3.0.0

129f93a

[12.0][FIX] Brand not required on vendor bill

e360bbd

[FIX] Check brand requirement constraint

b2dc05b

[FIX] Override is brand required

908f29c

account_brand 12.0.3.0.1

8ff63b7

[12.0][FIX] Create credit note with brand

525870d

account_brand 12.0.3.0.2

c843a69

[IMP] - set the invoice line analytic account at brand change

18a83e6

[FIX] - brand_id field in invoice form view is editable only in draft…

10744e4

… state

[IMP] - Add unit tests

efb28db

account_brand 12.0.3.0.3

916bb7d

[12.0][IMP] - Add res partner account brand

af454c0

[IMP] - Add account type constrains and domain

096e7f3

[FIX] - Fix brand onchange

3ce135d

[FIX] Invoice account_id

6b78853

account_brand 12.0.3.1.0

f751596

[MIG] account_brand: Migration to 13.0

f850ace

[ADD] - add sbejaoui as maintainer [IMP] - move brand config section outside multi_company section [FIX] - add brand_use_level to fields_view_get fields

vimalpatelserpentcs and others added 17 commits August 2, 2024 10:57

[IMP]account_brand: If we can't set analytic account in brand then us…

a5b1761

…er can't fill up analytic account on invoice lines

account_brand 15.0.1.0.1

816da83

[16.0][MIG] - migration brand & account_brand to 16.0

6dbe02f

[UPD] Update account_brand.pot

ebc2fb2

[UPD] README.rst

46bc4f8

[UPD] Update account_brand.pot

4448eb8

Update translation files

2580292

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: brand-16.0/brand-16.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-account_brand/

Translated using Weblate (German)

a431818

Currently translated at 86.3% (19 of 22 strings) Translation: brand-16.0/brand-16.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-account_brand/de/

[UPD] Update account_brand.pot

5c12db2

Update translation files

a089630

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: brand-16.0/brand-16.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-account_brand/

Translated using Weblate (Croatian)

db3f8c3

Currently translated at 72.7% (16 of 22 strings) Translation: brand-16.0/brand-16.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-account_brand/hr/

Translated using Weblate (Croatian)

49df01d

Currently translated at 100.0% (22 of 22 strings) Translation: brand-16.0/brand-16.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-account_brand/hr/

Translated using Weblate (Spanish)

ed18927

Currently translated at 100.0% (22 of 22 strings) Translation: brand-16.0/brand-16.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-account_brand/es/

Added translation using Weblate (Spanish (Argentina))

78c7bd5

Translated using Weblate (Spanish (Argentina))

fab13f8

Currently translated at 100.0% (22 of 22 strings) Translation: brand-16.0/brand-16.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-account_brand/es_AR/

[UPD] README.rst

b08bf51

[IMP] account_brand: pre-commit auto fixes

63314e4

RicardCForgeFlow force-pushed the 17.0-mig-account_brand branch from b90df1a to dd02e02 Compare August 2, 2024 09:03

FernandoRomera approved these changes Aug 2, 2024

View reviewed changes

bosd suggested changes Nov 3, 2024

View reviewed changes

GuillemCForgeFlow suggested changes Nov 6, 2024

View reviewed changes

account_brand/views/account_move_views.xml Outdated Show resolved Hide resolved

account_brand/views/account_move_views.xml Show resolved Hide resolved

RicardCForgeFlow force-pushed the 17.0-mig-account_brand branch from dd02e02 to 01d7361 Compare November 6, 2024 12:16

GuillemCForgeFlow suggested changes Nov 6, 2024

View reviewed changes

RicardCForgeFlow force-pushed the 17.0-mig-account_brand branch from 01d7361 to df24c1b Compare November 6, 2024 16:20

[MIG] account_brand: Migration to 17.0

00ea096

RicardCForgeFlow force-pushed the 17.0-mig-account_brand branch from df24c1b to 00ea096 Compare November 6, 2024 16:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] account_brand #193

[17.0][MIG] account_brand #193

RicardCForgeFlow commented Mar 11, 2024

GuillemCForgeFlow Mar 11, 2024 •

edited

Loading

FernandoRomera Jul 23, 2024

FernandoRomera Jul 23, 2024

github-actions bot commented Jul 14, 2024

FernandoRomera left a comment

bosd left a comment

GuillemCForgeFlow commented Nov 6, 2024

bosd commented Nov 6, 2024

RicardCForgeFlow commented Nov 6, 2024

GuillemCForgeFlow Nov 6, 2024

bosd Nov 6, 2024

GuillemCForgeFlow Nov 6, 2024

GuillemCForgeFlow Nov 6, 2024

bosd Nov 6, 2024

bosd commented Nov 6, 2024

[17.0][MIG] account_brand #193

Are you sure you want to change the base?

[17.0][MIG] account_brand #193

Conversation

RicardCForgeFlow commented Mar 11, 2024

GuillemCForgeFlow Mar 11, 2024 • edited Loading

Choose a reason for hiding this comment

FernandoRomera Jul 23, 2024

Choose a reason for hiding this comment

FernandoRomera Jul 23, 2024

Choose a reason for hiding this comment

github-actions bot commented Jul 14, 2024

FernandoRomera left a comment

Choose a reason for hiding this comment

bosd left a comment

Choose a reason for hiding this comment

GuillemCForgeFlow commented Nov 6, 2024

bosd commented Nov 6, 2024

RicardCForgeFlow commented Nov 6, 2024

GuillemCForgeFlow Nov 6, 2024

Choose a reason for hiding this comment

bosd Nov 6, 2024

Choose a reason for hiding this comment

GuillemCForgeFlow Nov 6, 2024

Choose a reason for hiding this comment

GuillemCForgeFlow Nov 6, 2024

Choose a reason for hiding this comment

bosd Nov 6, 2024

Choose a reason for hiding this comment

bosd commented Nov 6, 2024

GuillemCForgeFlow Mar 11, 2024 •

edited

Loading