Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][ADD] account_invoice_bank_brand #151

Open
wants to merge 1 commit into
base: 12.0
Choose a base branch
from
Open

[12.0][ADD] account_invoice_bank_brand #151

wants to merge 1 commit into from

Conversation

qgroulard
Copy link
Contributor

Companies may use one bank account per brand.
This module allows to configure on each brand which bank account to use for customer invoices.

@sbejaoui sbejaoui added this to the 12.0 milestone Jan 31, 2023
@sbejaoui sbejaoui added the no stale Use this label to prevent the automated stale action from closing this PR/Issue. label Feb 16, 2023
@bosd
Copy link

bosd commented Jun 17, 2023

@qgroulard Can you trigger the creation of a runboat?

@qgroulard qgroulard force-pushed the 12.0-account_invoice_brank_brand-qgr branch from eb593b2 to 6d3cd92 Compare June 19, 2023 07:28
bosd
bosd approved these changes Jul 6, 2023
View reviewed changes
Copy link

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review LGTM

@bosd
Copy link

bosd commented Aug 11, 2023

@OCA\brand-maintainers, @pedrobaeza Can you please merge this?

@pedrobaeza
Copy link
Member

Travis appears red.

@qgroulard
Copy link
Contributor Author

Travis appears red.

Doesn't look like it has anything to do with this PR though.

@dreispt
Copy link
Member

dreispt commented May 2, 2024

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@dreispt The rebase process failed, because command git push --force acsone tmp-pr-151:12.0-account_invoice_brank_brand-qgr failed with output:

remote: Permission to acsone/brand.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/acsone/brand/': The requested URL returned error: 403

@sbejaoui
Copy link
Contributor

sbejaoui commented May 2, 2024

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@sbejaoui The rebase process failed, because command git push --force acsone tmp-pr-151:12.0-account_invoice_brank_brand-qgr failed with output:

remote: Permission to acsone/brand.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/acsone/brand/': The requested URL returned error: 403

@bosd
Copy link

bosd commented May 2, 2024

@qgroulard can you give a try to fix this?

@qgroulard
Copy link
Contributor Author

@qgroulard can you give a try to fix this?

Mmmh... I think there is a problem with Travis for branch 12.0, I don't know how to solve that though.

@bosd
Copy link

bosd commented May 8, 2024

Ooh maybe a 'copier update' of the 12.0 branch will solve it.

@dreispt
Copy link
Member

dreispt commented May 9, 2024

Pre-commit of the repo was updated last week.
I think what is needed is to rebase the branch on the latest 12.0.

@qgroulard qgroulard force-pushed the 12.0-account_invoice_brank_brand-qgr branch from 6d3cd92 to bff93db Compare May 13, 2024 08:03
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@qgroulard
Copy link
Contributor Author

@bosd Fixed !

@dreispt
Copy link
Member

dreispt commented May 16, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-151-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 16, 2024
@OCA-git-bot
Merge PR #151 into 12.0
2d42c75 
Signed-off-by dreispt
@dreispt
Copy link
Member

dreispt commented May 18, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-151-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 18, 2024
@OCA-git-bot
Merge PR #151 into 12.0
87b9755 
Signed-off-by dreispt
@bosd
Copy link

bosd commented Jun 29, 2024

Looks like the bot is stuck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbejaoui sbejaoui sbejaoui approved these changes

@bosd bosd bosd approved these changes

Assignees

@qgroulard qgroulard

Labels
approved bot is merging ⏳ help wanted needs fixing no stale Use this label to prevent the automated stale action from closing this PR/Issue. ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@qgroulard @bosd @pedrobaeza @dreispt @OCA-git-bot @sbejaoui