Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] account_avatax_oca: fix unbalanced error on save #377

Merged
merged 1 commit into from
Nov 9, 2023
Merged

[FIX] account_avatax_oca: fix unbalanced error on save #377

merged 1 commit into from
Nov 9, 2023

Conversation

dreispt
Copy link
Member

@dreispt dreispt commented Oct 10, 2023 •
edited
Loading

No description provided.

@dreispt dreispt changed the title 16 dr fix avatax unbalanced [FIX] account_avatax_oca: fix unbalanced error on save Oct 10, 2023
@dreispt
Copy link
Member Author

dreispt commented Oct 10, 2023

@patrickrwilson Can you test this please?

@patrickrwilson
Copy link

@dreispt confirmed, this fixes the unbalance issue

patrickrwilson
patrickrwilson approved these changes Oct 10, 2023
View reviewed changes
Copy link

@patrickrwilson patrickrwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as this indeed fixes the unbalanced issue

@dreispt
Copy link
Member Author

dreispt commented Nov 9, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-377-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 9, 2023
@OCA-git-bot
Merge PR #377 into 16.0
379100f 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-377-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@dreispt
Copy link
Member Author

dreispt commented Nov 9, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-377-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 9, 2023
@OCA-git-bot
Merge PR #377 into 16.0
196b489 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-377-by-dreispt-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4d46c9b into OCA:16.0 Nov 9, 2023
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 54ac8a8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickrwilson patrickrwilson patrickrwilson approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreispt @patrickrwilson @OCA-git-bot