Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] account_avatax_oca: tax calculation improvements #371

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

RLeeOSI
Copy link

@RLeeOSI RLeeOSI commented Aug 3, 2023

Improvements to v16 migration

Calculates taxes properly for lines that have split taxes. E.g. in Tennessee taxes, one line for $100 may have two applicable taxes, 4% on $75 and 4.5% on $25. Odoo should consider the total tax amount for that line ($4.13) and compute the tax rate (4.125%) based on that.

Bugfixes for unbalanced entry error, changed core Odoo method to _sync_dynamic_lines to recompute journal items

@OCA-git-bot
Copy link
Contributor

Hi @dreispt,
some modules you are maintaining are being modified, check this out!

@dreispt
Copy link
Member

dreispt commented Aug 3, 2023

@RLeeOSI Thank you. Any chace you can separate the two module changes into different commits?
Thant would be helpful in the future, when it comes to migrate each of the modules to v17.

Thanks

@RLeeOSI RLeeOSI force-pushed the 16.0-fix-account-avatax-oca-unbalance branch from ac34b85 to b43395a Compare August 3, 2023 19:44
@RLeeOSI
Copy link
Author

RLeeOSI commented Aug 3, 2023

@dreispt Commits are split by module

@dreispt
Copy link
Member

dreispt commented Oct 10, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-371-by-dreispt-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 10, 2023
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-371-by-dreispt-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

* [FIX] compound rate computation adjustment

* [FIX] model inconsistencies in migration

* [FIX] replace _recompute_dynamic_lines with _sync_dynamic_lines

* [FIX] unbalanced entries error
* [FIX] compound rate computation adjustment
@dreispt dreispt force-pushed the 16.0-fix-account-avatax-oca-unbalance branch from b43395a to 16f7d84 Compare October 10, 2023 17:28
@dreispt
Copy link
Member

dreispt commented Oct 10, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-371-by-dreispt-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 35ac7cf into OCA:16.0 Oct 10, 2023
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fb68462. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants