-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] account_avatax_oca: tax calculation improvements #371
[16.0][FIX] account_avatax_oca: tax calculation improvements #371
Conversation
Hi @dreispt, |
@RLeeOSI Thank you. Any chace you can separate the two module changes into different commits? Thanks |
ac34b85
to
b43395a
Compare
@dreispt Commits are split by module |
/ocabot merge minor |
What a great day to merge this nice PR. Let's do it! |
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-371-by-dreispt-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
* [FIX] compound rate computation adjustment * [FIX] model inconsistencies in migration * [FIX] replace _recompute_dynamic_lines with _sync_dynamic_lines * [FIX] unbalanced entries error
* [FIX] compound rate computation adjustment
b43395a
to
16f7d84
Compare
/ocabot merge minor |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at fb68462. Thanks a lot for contributing to OCA. ❤️ |
Improvements to v16 migration
Calculates taxes properly for lines that have split taxes. E.g. in Tennessee taxes, one line for $100 may have two applicable taxes, 4% on $75 and 4.5% on $25. Odoo should consider the total tax amount for that line ($4.13) and compute the tax rate (4.125%) based on that.
Bugfixes for unbalanced entry error, changed core Odoo method to _sync_dynamic_lines to recompute journal items