Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][ADD] account_avatax_exemption #162

Merged
merged 14 commits into from
Jun 13, 2021
Merged

[14.0][ADD] account_avatax_exemption #162

merged 14 commits into from
Jun 13, 2021

Conversation

SodexisTeam
Copy link
Member

@SodexisTeam SodexisTeam commented Dec 31, 2020 •
edited
Loading

Needs 14.0 migrate of account_avatax and account_avatax_sale
Depends on #150

@stephankeller @dreispt @dnplkndll @max3903

@atchuthan atchuthan force-pushed the 14.0-add-avatax-exemption branch 2 times, most recently from 96ea62b to 60eafbf Compare January 7, 2021 10:41
@max3903 max3903 added this to the 14.0 milestone Feb 5, 2021
@max3903 max3903 changed the title [ADD] Add Avatax Exemption module to 14.0 [ADD] account_avatax_exemption Feb 5, 2021
@dreispt dreispt changed the title [ADD] account_avatax_exemption [14.0][ADD] account_avatax_exemption Apr 16, 2021
@dreispt dreispt self-requested a review April 16, 2021 08:38
odoo-sh
odoo-sh approved these changes May 19, 2021
View reviewed changes
Copy link

@odoo-sh odoo-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreispt Daniel, this has been in production for Kencove for about two months now with no issue, so can you please approve it? Thanks.

dreispt
dreispt reviewed May 19, 2021
View reviewed changes
Copy link
Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a readme subdirectory with text fragments, on both modules, so that a nice readme is automatically generated later?

@atchuthan
Copy link
Member

@dreispt
Added basic readme.rst using maintainer-tools.
We will update the readme.rst later in more detail with a new PR.

@atchuthan
Copy link
Member

rebased the commits with latest 14.0 branch

@atchuthan
Copy link
Member

Runbot and pre-commit are green now!!

@dreispt
Copy link
Member

dreispt commented Jun 13, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-162-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ca81e12 into OCA:14.0 Jun 13, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ac047ce. Thanks a lot for contributing to OCA. ❤️

@dreispt
Copy link
Member

dreispt commented Jun 14, 2021

@atchuthan The account_avatax_exemption_base module has a License issue: it is LGPL but depends on AGPL modules.
It needs to be changed to AGPL.

@atchuthan atchuthan deleted the 14.0-add-avatax-exemption branch June 17, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odoo-sh odoo-sh odoo-sh approved these changes

@dreispt dreispt dreispt approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@SodexisTeam @atchuthan @dreispt @OCA-git-bot @odoo-sh @max3903 @amkarthik