[FIX] account_move_name_sequence: redefine _onchange_journal_id #1755
Conversation
|
Hi @moylop260, @alexis-via, @luisg123v, @frahikLV, |
In v16, _onchange_journal_id is defined to update name when journal_id is modified During the creation of new account.move, this onchange is triggered and called the standard _compute_name method How to reproduce issue: * Create new invoice => Name is defined instead of to be 'Draft'
mde-scopea
force-pushed
the
16.0-fix-account_move_name_sequence-draft
branch
from
c35d237
to
80c5077
Compare
|
Could you share the odoo original code (link) where it is triggered, please? @luisg123v Could you check it, please? |
|
I got it Thank you! For record the permalink: Is it the unique side using a call directly to |
|
@matteoopenf I prefer redefine the onchange method w/o calling super to avoid other odoo calculations For my information, in v14, any reasons for changing the compute instead of keeping _compute_name from odoo ? If we restore _compute_name on the field name and put the code of _compute_name_by_sequence to replace odoo code in _compute_name, we cover all cases ?! |
|
@alexis-via What do you think about last comment? |
|
In case poter module call same Method is a problem Matteo ***@***.*** Il giorno 7 nov 2023, alle ore 09:09, mde-spring ***@***.***> ha scritto:
@matteoopenf I prefer redefine the onchange method w/o calling super to avoid other odoo calculations
@moylop260 Another call in write
For my information, in v14, any reasons for changing the compute instead of keeping _compute_name from odoo ?
4aeaa9c#diff-0cce1efec70b54da80f909139ddbeca882923c9ade8437a54d87d510d0c7aa6bR11
If we restore _compute_name on the field name and put the code of _compute_name_by_sequence to replace odoo code in _compute_name, we cover all cases ?!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
Openforce Srls Unipersonale | www.openforce.it | 02 21119472 | Via Tiziano,32 20145 Milano
|
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 0c43ff9. Thanks a lot for contributing to OCA. ❤️ |
In v16, _onchange_journal_id is defined to update name when journal_id is modified.
During the creation of new account.move, this onchange is triggered and called the standard _compute_name method
How to reproduce issue: