Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] account_invoice_start_end_dates: Migration to 18.0 #309

Open
wants to merge 49 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] account_invoice_start_end_dates: Migration to 18.0 #309

wants to merge 49 commits into from

Conversation

xaviedoanhduy
Copy link

supersedes: #307

alexis-via and others added 30 commits November 13, 2024 14:32
@alexis-via @xaviedoanhduy
Port account_cutoff_base and account_cutoff_prepaid to Odoo v9
6570218 
Extract a new module account_invoice_start_end_dates from account_cutoff_prepaid
@adrienpeiffer @xaviedoanhduy
Migration of account_cutoff modules to 10.0
e47aa96
@xaviedoanhduy
account_invoice_start_end_dates: Migration to 11.0
7bb3b3f
@xaviedoanhduy
Savepoint tests invoice_start
2c532cc
@oca-transbot @xaviedoanhduy
OCA Transbot updated translations from Transifex
f779821
@xaviedoanhduy
account_invoice_start_end_dates: Migration to 12.0 account_invoice_st…
8fd3424 
…art_end_dates: fixing tests fixing product not found convert mline dates to string fixing flake8 account_invoice_start_end_dates: fixing tests fixing product not found convert mline dates to string fixing flake8 putting removed licences back fix tests fix flake8 fix pylint issues

[12.0-mig-account] fix unit tests

fixup! [12.0-mig-account] fix unit tests

fixup! fixup! [12.0-mig-account] fix unit tests
@OCA-git-bot @xaviedoanhduy
icon.png
b0177f4
@alexis-via @xaviedoanhduy
[MIG] account_invoice_start_end_dates to v13
aef2e3f
@alexis-via @xaviedoanhduy
Black
7ada979
@alexis-via @xaviedoanhduy
Use super() instead of super(classname, self)
6ccd2eb
@alexis-via @xaviedoanhduy
Black and other pre-commit stuff
01199a8
@alexis-via @xaviedoanhduy
FIX visibility of forecast button
05c1201 
Default value for cutoff date is end date of previous fiscal year
@sbidoul @xaviedoanhduy
[FIX] lint issues
6a4c08d
@alexis-via @xaviedoanhduy
[MIG] account_invoice_start_end_dates from 13 to 14
58160b2
@OCA-git-bot @xaviedoanhduy
account_invoice_start_end_dates 14.0.1.0.1
22ac97f
@Yvesldff @xaviedoanhduy
Added translation using Weblate (French (France))
8252e68
@Yvesldff @xaviedoanhduy
Translated using Weblate (French (France))
bf7de0f 
Currently translated at 88.2% (15 of 17 strings)

Translation: account-closing-14.0/account-closing-14.0-account_invoice_start_end_dates
Translate-URL: https://translation.odoo-community.org/projects/account-closing-14-0/account-closing-14-0-account_invoice_start_end_dates/fr_FR/
@pedrocs-exo @xaviedoanhduy
Translated using Weblate (Portuguese)
b582310 
Currently translated at 100.0% (14 of 14 strings)

Translation: account-closing-14.0/account-closing-14.0-account_invoice_start_end_dates
Translate-URL: https://translation.odoo-community.org/projects/account-closing-14-0/account-closing-14-0-account_invoice_start_end_dates/pt/
@SicurSam @xaviedoanhduy
Translated using Weblate (Italian)
643ea0c 
Currently translated at 100.0% (14 of 14 strings)

Translation: account-closing-14.0/account-closing-14.0-account_invoice_start_end_dates
Translate-URL: https://translation.odoo-community.org/projects/account-closing-14-0/account-closing-14-0-account_invoice_start_end_dates/it/
@alexis-via @xaviedoanhduy
[MIG] account_invoice_start_end_dates to v15
c41f986
@gregory-moka @xaviedoanhduy
Translated using Weblate (French)
7bc0f11 
Currently translated at 100.0% (14 of 14 strings)

Translation: account-closing-15.0/account-closing-15.0-account_invoice_start_end_dates
Translate-URL: https://translation.odoo-community.org/projects/account-closing-15-0/account-closing-15-0-account_invoice_start_end_dates/fr/
@FrancoMaxime @xaviedoanhduy
[MIG] account_invoice_start_end_dates: Migration to 16.0
2658401
@marylla @xaviedoanhduy
Added translation using Weblate (German)
80ba11c
@marylla @xaviedoanhduy
Translated using Weblate (German)
9c2133f 
Currently translated at 100.0% (14 of 14 strings)

Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates
Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/de/
@mymage @xaviedoanhduy
Translated using Weblate (Italian)
1700e0e 
Currently translated at 100.0% (13 of 13 strings)

Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates
Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/it/
@alexis-via @xaviedoanhduy
[IMP] account_invoice_start_end_dates: add start/end dates in tree vi…
7ece921 
…ew of move lines
@OCA-git-bot @xaviedoanhduy
account_invoice_start_end_dates 16.0.1.1.0
ad4b7d5
@badbole @xaviedoanhduy
Translated using Weblate (Croatian)
f0f61f0 
Currently translated at 100.0% (13 of 13 strings)

Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates
Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/hr/
@mostafabarmshory @xaviedoanhduy
Added translation using Weblate (Persian)
c7d4c87
@mostafabarmshory @xaviedoanhduy
Translated using Weblate (Persian)
027bde7 
Currently translated at 15.3% (2 of 13 strings)

Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates
Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/fa/
sanrav and others added 18 commits November 13, 2024 16:27
@sanrav @xaviedoanhduy
Translated using Weblate (French)
0219c67 
Currently translated at 100.0% (13 of 13 strings)

Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates
Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/fr/
@sanrav @xaviedoanhduy
Translated using Weblate (French (France) (fr_FR))
5714090 
Currently translated at 100.0% (13 of 13 strings)

Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates
Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/fr_FR/
@mymage @xaviedoanhduy
Translated using Weblate (Italian)
21b8e92 
Currently translated at 100.0% (13 of 13 strings)

Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates
Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/it/
@mymage @xaviedoanhduy
Translated using Weblate (Italian)
2704a41 
Currently translated at 100.0% (13 of 13 strings)

Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates
Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/it/
@xaviedoanhduy
Translated using Weblate (French)
69d30b7 
Currently translated at 100.0% (13 of 13 strings)

Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates
Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/fr/
@alexis-via @xaviedoanhduy
cutoff modules: improve strings
c138ee0 
Remove deprecated POT files
@OCA-git-bot @xaviedoanhduy
account_invoice_start_end_dates 16.0.1.2.0
41ab9d4
@Ivorra78 @xaviedoanhduy
Added translation using Weblate (Spanish)
c7257c8
@Ivorra78 @xaviedoanhduy
Translated using Weblate (Spanish)
d5edc59 
Currently translated at 100.0% (13 of 13 strings)

Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates
Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/es/
@badbole @xaviedoanhduy
Translated using Weblate (Croatian)
fa463c0 
Currently translated at 92.3% (12 of 13 strings)

Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates
Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/hr/
@xaviedoanhduy
Translated using Weblate (French)
eb70bf1 
Currently translated at 100.0% (13 of 13 strings)

Translation: account-closing-16.0/account-closing-16.0-account_invoice_start_end_dates
Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_invoice_start_end_dates/fr/
@sbidoul @xaviedoanhduy
[TRN] remove fr_FR.po
c540b92 
Co-authored-by: Alexis de Lattre <[email protected]>
@thaolt99 @xaviedoanhduy
[IMP] account_invoice_start_end_dates: pre-commit auto fixes
500d89c
@thaolt99 @xaviedoanhduy
[MIG] account_invoice_start_end_dates: Migration to 17.0
9b252d6
@OCA-git-bot @xaviedoanhduy
[BOT] post-merge updates
0b1a191
@alexis-via @xaviedoanhduy
[FIX] account_cutoff_start_end_dates: fix view migration to v17
57fe061
@mymage @xaviedoanhduy
Translated using Weblate (Italian)
9a130ab 
Currently translated at 100.0% (13 of 13 strings)

Translation: account-closing-17.0/account-closing-17.0-account_invoice_start_end_dates
Translate-URL: https://translation.odoo-community.org/projects/account-closing-17-0/account-closing-17-0-account_invoice_start_end_dates/it/
@OCA-git-bot @xaviedoanhduy
[BOT] post-merge updates
5a687a9
@xaviedoanhduy xaviedoanhduy mentioned this pull request Nov 14, 2024
Open
@xaviedoanhduy xaviedoanhduy force-pushed the 18.0-mig-account_invoice_start_end_dates branch from ed5e932 to fc3030f Compare November 18, 2024 04:28
@xaviedoanhduy xaviedoanhduy force-pushed the 18.0-mig-account_invoice_start_end_dates branch from fc3030f to 6f26308 Compare November 18, 2024 04:53
ajaniszewska-dev
ajaniszewska-dev reviewed Nov 19, 2024
View reviewed changes
account_invoice_start_end_dates/tests/test_invoice_start_end_dates.py
0,
0,
{
"product_id": self.env.ref("product.product_product_5").id,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at this test case i guess we test positive case here - all previous lines have dates set and we don't expect any error to be raised for product_product_5 because probably this product has no flag set - i'd maybe add some comments in this case + test negative case (where error should be raised)?

Copy link
Author

@xaviedoanhduy xaviedoanhduy Nov 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if moveline.start_date and not moveline.end_date:
    ...
if moveline.end_date and not moveline.start_date:
    ...
if (
    moveline.end_date
    and moveline.start_date
    and moveline.start_date > moveline.end_date
):

hi @ajaniszewska-dev, I had the same question as you, I'm not sure what the author of this module intended, because the above conditions require at least 1 value to be assigned to start_date and end_date, so if no value is inputed, no error will be raised. I tried adding a filter in the lookup function like:

def _check_start_end_dates(self):
    for moveline in self.filtered("must_have_date"):
         ...

then the error will be raised, and I wonder if that change affects the original purpose of this module?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexis-via probably your input here would be valuable.

ajaniszewska-dev
ajaniszewska-dev approved these changes Nov 19, 2024
View reviewed changes
Copy link

@ajaniszewska-dev ajaniszewska-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, i'd slightly improve test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaniszewska-dev ajaniszewska-dev ajaniszewska-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.