[16.0][IMP] stock: pre-compute quantity_done #4475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Jun 14, 2024
chienandalu
force-pushed
the
16.0-imp-stock-perf
branch
2 times, most recently
from
e16e7ba
to
74a5994
Compare
|
Hi @chienandalu. What is the state of this PR ? could you apply @pedrobaeza proposal to get this one merged ? |
chienandalu
force-pushed
the
16.0-imp-stock-perf
branch
from
74a5994
to
53d5dc8
Compare
legalsylvain
approved these changes
Nov 8, 2024
The field stock.move.quantity_done has passed to be stored. In large databases (millions of records) it takes a good amount of time to compute it by the ORM, so it's worth it to pre-compute its values as much as possible. TT46020
chienandalu
force-pushed
the
16.0-imp-stock-perf
branch
from
53d5dc8
to
dabc812
Compare
|
I had the other query to reformat to a more compact version. Now it should be ok |
pedrobaeza
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field stock.move.quantity_done has passed to be stored.
In large databases (millions of records) it takes a good amount of time to compute it by the ORM, so it's worth it to pre-compute its values as much as possible.
In a database with 12M stock_move records we go from 1h15m with pure ORM to 18minutes
cc @Tecnativa TT46020