Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][OU-ADD] hr_holidays #3913

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions openupgrade_scripts/scripts/hr_holidays/16.0.1.5/post-migration.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# Copyright 2023 Coop IT Easy (https://coopiteasy.be)
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).

from openupgradelib import openupgrade


def set_allocation_validation_type(env):
"""Operate like the _compute_allocation_validation_type() function.

It set "no" by default except if employee_request is set to "no"
where it set "officer".
"""
openupgrade.logged_query(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only need to reallocate those with set value to the corresponding one. Please don't write the rest that are OK.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As further explanation, imagine there's an extra module adding a new validation type. You are overwriting the leave types with this new validation type in this SQL.

env.cr, "UPDATE hr_leave_type SET allocation_validation_type = 'no'"
)
openupgrade.logged_query(
env.cr,
"""UPDATE hr_leave_type
SET allocation_validation_type = 'officer'
WHERE employee_requests = 'no'
""",
)


@openupgrade.migrate()
def migrate(env, version):
set_allocation_validation_type(env)
openupgrade.load_data(env.cr, "hr_holidays", "16.0.1.5/noupdate_changes.xml")
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
---Models in module 'hr_holidays'---
new model hr.holidays.cancel.leave [transient]
# NOTHING TO DO: transient model

new model hr.leave.stress.day
# NOTHING TO DO: new feature

---Fields in module 'hr_holidays'---
hr_holidays / hr.leave / active (boolean) : NEW
# NOTHING TO DO: default value is True.

hr_holidays / hr.leave / request_unit_custom (boolean) : DEL
# NOTHING TO DO: not needed anymore. See : https://github.com/odoo/odoo/commit/81c8a0564d54c981e65a6ed3b2c70dd792d59a46

hr_holidays / hr.leave.accrual.level / postpone_max_days (integer) : NEW
hr_holidays / hr.leave.stress.day / color (integer) : NEW hasdefault: default
hr_holidays / hr.leave.stress.day / company_id (many2one) : NEW relation: res.company, required, hasdefault: default
hr_holidays / hr.leave.stress.day / department_ids (many2many) : NEW relation: hr.department
hr_holidays / hr.leave.stress.day / end_date (date) : NEW required
hr_holidays / hr.leave.stress.day / name (char) : NEW required
hr_holidays / hr.leave.stress.day / resource_calendar_id (many2one): NEW relation: resource.calendar
hr_holidays / hr.leave.stress.day / start_date (date) : NEW required
# NOTHING TO DO: new feature

hr_holidays / hr.leave.type / allocation_validation_type (selection): selection_keys is now '['no', 'officer']' ('['no', 'officer', 'set']')
# DONE: post-migration: compute new value for allocation_validation_type

---XML records in module 'hr_holidays'---
NEW ir.actions.act_window: hr_holidays.hr_leave_stress_day_action
DEL ir.actions.act_window.view: hr_holidays.hr_leave_action_my_view_form
DEL ir.actions.act_window.view: hr_holidays.hr_leave_action_my_view_tree
NEW ir.model.access: hr_holidays.access_hr_holidays_cancel_leave
NEW ir.model.access: hr_holidays.access_hr_leave_stress_day_manager
NEW ir.model.access: hr_holidays.access_hr_leave_stress_day_user
NEW ir.model.constraint: hr_holidays.constraint_hr_leave_stress_day_date_from_after_day_to
NEW ir.rule: hr_holidays.hr_leave_stress_day_rule_multi_company (noupdate)
NEW ir.ui.menu: hr_holidays.hr_holidays_stress_day_menu_configuration
NEW ir.ui.view: hr_holidays.hr_holidays_cancel_leave_form
NEW ir.ui.view: hr_holidays.hr_leave_report_view_form
NEW ir.ui.view: hr_holidays.hr_leave_stress_day_view_form
NEW ir.ui.view: hr_holidays.hr_leave_stress_day_view_list
NEW ir.ui.view: hr_holidays.hr_leave_stress_day_view_search
NEW ir.ui.view: hr_holidays.hr_leave_view_kanban_approve_department
# NOTHING TO DO: managed by the ORM
Loading