Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align example section titles #78

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Align example section titles #78

merged 4 commits into from
Oct 15, 2024
+6 −6

Conversation

ralfhandl
Copy link
Contributor

Fixes #73

@ralfhandl ralfhandl requested review from kevinswiber and a team October 14, 2024 12:44
@ralfhandl ralfhandl mentioned this pull request Oct 14, 2024
Closed
@ralfhandl ralfhandl added this to the Release 1.0 milestone Oct 14, 2024
@ralfhandl ralfhandl mentioned this pull request Oct 14, 2024
Closed
kevinswiber
kevinswiber suggested changes Oct 14, 2024
View reviewed changes
Copy link

@kevinswiber kevinswiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title in one of the examples, on line 172, still reads "Targeted Overlays". Can we update this to be the same as the Markdown title for the example? Otherwise, LGTM! Thank you!

@ralfhandl ralfhandl mentioned this pull request Oct 14, 2024
Merged
mikekistler
mikekistler approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@ralfhandl ralfhandl requested a review from a team October 15, 2024 06:19
@lornajane lornajane merged commit 58a3c2a into OAI:main Oct 15, 2024
1 check passed
@ralfhandl ralfhandl deleted the Align-example-section-titles branch October 15, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikekistler mikekistler mikekistler approved these changes

@lornajane lornajane lornajane approved these changes

@kevinswiber kevinswiber Awaiting requested review from kevinswiber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging this pull request may close these issues.

consistency on the naming of Overlay / Overlays
4 participants
@ralfhandl @kevinswiber @lornajane @mikekistler