Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop optional flake inputs #38

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Drop optional flake inputs #38

merged 1 commit into from
Sep 10, 2024

Conversation

SuperSandro2000
Copy link
Member

No description provided.

@SuperSandro2000
Copy link
Member Author

Sadly this only works on unstable, not stable....

@SuperSandro2000 SuperSandro2000 marked this pull request as draft July 19, 2024 13:03
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review September 10, 2024 13:34
@MarcelCoding
Copy link
Member

How would you now override these transient inputs? This was the reason we've put them in the first place.

@SuperSandro2000
Copy link
Member Author

They are not required for the module or the package, only for local development. So you don't because we don't need them.

@MarcelCoding
Copy link
Member

nvm i am blind

@MarcelCoding MarcelCoding merged commit 0770d03 into main Sep 10, 2024
2 checks passed
@MarcelCoding MarcelCoding deleted the drop-optional-flake-inputs branch September 10, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelCoding MarcelCoding MarcelCoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuperSandro2000 @MarcelCoding