Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing decay data #12

Merged
merged 1 commit into from
May 19, 2022
Merged

Added missing decay data #12

merged 1 commit into from
May 19, 2022

Conversation

Rademacher
Copy link

Manually added decay data for a number of excited states for which production cross sections exist but the decay data does not appear in the reduced decay library. Data taken from unreduced ENDFVIII library, with the exception of Th-229* not contained in ENDF and instead taken from JEFF3.3.

@Rademacher
Added missing decay data
158775a 
Manually added decay data for a number of excited states for which production cross sections exist but the decay data does not appear in the reduced decay library. Data taken from unreduced ENDFVIII library, with the exception of Th-229* not contained in ENDF and instead taken from JEFF3.3.
@Rademacher Rademacher mentioned this pull request Apr 20, 2022
Open
jung-benjamin
jung-benjamin reviewed Apr 21, 2022
View reviewed changes
Copy link
Member

@jung-benjamin jung-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to instead create a second library called, for example, decay_lib_extended and add the option to switch decay_libraries?

I assume the reduced library is used as default for a purpose and would be reluctant to change that.

jung-benjamin
jung-benjamin approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@jung-benjamin jung-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to add these to the default library, since there is no reason to exclude them.

@jung-benjamin
Copy link
Member

Closes #11

@Rademacher Rademacher merged commit 0832c8d into main-nvd May 19, 2022
@Rademacher Rademacher deleted the add_missing_decays branch May 19, 2022 11:28
jung-benjamin pushed a commit that referenced this pull request Jun 9, 2022
@jlanversin
Merge pull request #12 from Nuclear-Verification-and-Disarmament/add_…
69514ae 
…missing_decay_data

Added missing decay data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jung-benjamin jung-benjamin jung-benjamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rademacher @jung-benjamin