-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README loading text #6169
base: dev
Are you sure you want to change the base?
Conversation
This PR contains changes to XAML files. Verify that you've completed the following tasks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice improvement! Is there any other testing pending?
src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs
Outdated
Show resolved
Hide resolved
…kdown preview is set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating a Binding and Trigger!
I suggest re-testing the accessibility of this, since we've never used a LiveTextBlock with a trigger, would be good to just ensure it works properly with screen readers.
Bug
Fixes:
Description
Update the message displayed to the user when the README is loading, per the recommendation from the UX board. Ensure screen readers announce when the README is loading.
PR Checklist
Added testsLink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.