Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README loading text #6169

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

jgonz120
Copy link
Contributor

@jgonz120 jgonz120 commented Nov 26, 2024

Bug

Fixes:

Description

Update the message displayed to the user when the README is loading, per the recommendation from the UX board. Ensure screen readers announce when the README is loading.
image

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@jgonz120 jgonz120 requested a review from a team as a code owner November 26, 2024 22:30
Copy link

microsoft-github-policy-service bot commented Nov 26, 2024

This PR contains changes to XAML files. Verify that you've completed the following tasks:

donnie-msft
donnie-msft previously approved these changes Nov 26, 2024
Copy link
Contributor

@donnie-msft donnie-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice improvement! Is there any other testing pending?

Copy link
Contributor

@donnie-msft donnie-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating a Binding and Trigger!
I suggest re-testing the accessibility of this, since we've never used a LiveTextBlock with a trigger, would be good to just ensure it works properly with screen readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants