Skip to content

Commit

Permalink
Cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
nkolev92 committed Nov 14, 2024
1 parent 62ac4d1 commit 2187307
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -739,10 +739,9 @@ internal static void AddPrunedPackageReferences(PackageSpec spec, IEnumerable<IM
var tfm = item.GetProperty("TargetFramework") ?? string.Empty;

bool enabled = IsPropertyTrue(item, "RestoreEnablePackagePruning");
isPruningEnabled.Add(tfm, enabled);
isPruningEnabled[tfm] = enabled;
}


foreach (var item in GetItemByType(items, "PrunedPackageReference"))
{
var id = item.GetProperty("Id");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1993,7 +1993,7 @@ public static readonly List<object[]> PrunedPackageReferenceData
= new List<object[]>
{
new object[] { "true", new (string, string[])[] { ("PackageA", ["1.0.0"]) }, true },
new object[] { "true", new (string, string[])[] { ("PackageA", ["1.0.0"]) }, false },
new object[] { "false", new (string, string[])[] { ("PackageA", ["1.0.0"]) }, false },
};

[Theory]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2011,7 +2011,6 @@ await SimpleTestPackageUtility.CreateFolderFeedV3Async(

// Add tests with ranges, in particular where the specified version is in the range, but not the one actually selected.
// Add tests with ranges such as floating versions? This is interesting.
// When should the warning be raised? In NET 10 only?
// TODO NK - Clarify that packages can be pruned from PackageReferences.

// Here's why package driven dependencies should flow.
Expand Down

0 comments on commit 2187307

Please sign in to comment.