Cleanup2 #522
Merged
Cleanup2 #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on cleaning up unused imports and simplifying the codebase across multiple files. The most important changes include the removal of unused imports, minor adjustments to component properties, and the commenting out of unused variables.
Codebase simplification:
src/common/components/organisms/FidgetSettingsEditor.tsx: Removed the unusedFaTriangleExclamationimport fromreact-icons/fa6.src/common/components/organisms/LoadingSidebar.tsx: Removed the unusedBrandHeaderimport.src/common/components/organisms/Navigation.tsx: Simplified theIconcomponent usage by removing thearia-hiddenattribute.src/common/components/organisms/Player.tsx: Removed unused importsformatEthereumAddressandisAddressfromviem.src/common/components/organisms/Sidebar.tsx: Removed the unuseduseEffectimport andLoadingSidebarimport.Unused imports removal:
src/common/components/organisms/TabBar.tsx: Removed multiple unused imports includingfirst,useLoadFarcasterUser,useFarcasterSigner,memo,useEffect,useMemo,useState,useRouter,SpaceLookupInfo, andLink.src/common/components/pages/SpacePage.tsx: Removed the unusedmomentimport.src/common/fidgets/FidgetWrapper.tsx: Removed the unuseduseStateimport andBackArrowIconimport. [1] [2]src/common/lib/theme/ThemeSettingsEditor.tsx: Removed the unusedGiOpenBookandFaBookimports.src/fidgets/farcaster/Feed.tsx: Removed the unusedsizeimport.src/fidgets/farcaster/components/CastRow.tsx: Removed the unusedbytesToHexStringimport.src/fidgets/farcaster/components/CreateCast.tsx: Removed the unusedFC,use, andRichEmbedimports, and commented out unused variables. [1] [2] [3] [4]src/fidgets/farcaster/components/channelPicker.tsx: Removed the unusedCommandGroupimport.src/pages/api/signerRequests.ts: Removed the unusedNOGS_CONTRACT_ADDRandALCHEMY_APIimports.src/pages/homebase/[tabname].tsx: Removed the unusedisArrayandnoopimports. (src/pages/homebase/[tabname].tsxL7-L11)Commented out unused variables:
src/common/data/stores/app/space/spaceStore.ts: Commented out the unusedremoteTabvariable.