fix: only show new versions of spaces if they are newer than the local copies #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ryannorton
requested changes
Jul 11, 2024
| @@ -59,6 +60,16 @@ export const createHomeBaseStoreFunc = ( | |||
| const spaceConfig = JSON.parse( | |||
| await get().account.decryptEncryptedSignedFile(fileData), | |||
| ) as SpaceConfig; | |||
| const currentHomebase = get().homebase.homebaseConfig; | |||
| if ( | |||
| spaceConfig.timestamp && | |||
There was a problem hiding this comment.
Handle undefined spaceConfig
ryannorton
reviewed
Jul 11, 2024
| if ( | ||
| spaceConfig.timestamp && | ||
| currentHomebase && | ||
| currentHomebase.timestamp && |
There was a problem hiding this comment.
Should also return true if local config has a timestamp and the fetched one doesn't to fix this issue on existing users' next save
ryannorton
reviewed
Jul 11, 2024
| const currentLocalCopy = get().space.localSpaces[spaceId]; | ||
| if ( | ||
| spaceConfig && | ||
| spaceConfig.timestamp && |
There was a problem hiding this comment.
Should also return true if local config has a timestamp and the fetched one doesn't
|
@ryannorton Fixed comments |
ryannorton
pushed a commit
that referenced
this pull request
Jul 30, 2024
j-paterson
pushed a commit
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.