Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added watchdog #63

Merged
merged 1 commit into from
Nov 30, 2023
Merged

added watchdog #63

merged 1 commit into from
Nov 30, 2023

Conversation

dyldonahue
Copy link
Contributor

i added watchdog petting and initiaslzed the in pin to high. I pet it twice for every pet bc there was a confusing part in the datasheet that mentions two falling edges to reset timer. probably not needed but who cares

@dyldonahue dyldonahue requested a review from nwdepatie November 30, 2023 01:51
Copy link
Contributor

@nwdepatie nwdepatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good

void watchdog_pet(void)
{
//second iteration maybe redundant, datasheet unclear so we pet twice
HAL_GPIO_WritePin(Watchdog_Out_GPIO_Port, Watchdog_Out_Pin, GPIO_PIN_RESET);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna trust you on writing to it twice lol. My only concern is that there isn't a delay so it might be too fast for the watchdog to see, but I think its an issue that we will have to address when putting it on hardware

@dyldonahue dyldonahue merged commit 60c9f3b into develop/features Nov 30, 2023
1 check passed
@dyldonahue dyldonahue deleted the feature/watchdog branch November 30, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants