Created sht30 internal temp fault monitoring #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyldonahue
requested changes
Nov 9, 2023
Core/Inc/analyzer.h
Outdated
| @@ -4,6 +4,7 @@ | |||
| //#include <nerduino.h> Replace | |||
| #include "datastructs.h" | |||
| #include "segment.h" | |||
| #include "Core/Drivers/Embedded-Base/general/include/sht30.h" | |||
There was a problem hiding this comment.
ive discovered that for whatever reason it doesnt love the full path, so actually just "sht30.h" will work better
| /** | ||
| * @brief Create a new object to store the most recent data point for the temp sensor | ||
| */ | ||
| sht30_t* sht30data; |
There was a problem hiding this comment.
seems like the @brief got doubled here, but also dont think we need one at all. creating an sht30 object right nect to an acc data one is pretty self explanatory imo, so feel free to remove both
| @@ -115,14 +115,16 @@ Timer ocvTimer; | |||
|
|
|||
| bool is_first_reading_ = true; | |||
|
|
|||
| void push(AccumulatorData_t* data) | |||
| void push(AccumulatorData_t* data, sht30_t* sht30data) | |||
There was a problem hiding this comment.
just gonna wanna update the acual call of this function in main.c to use this new param as well
|
meerged through another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.