Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

81 fault priority #147

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

81 fault priority #147

wants to merge 10 commits into from

Conversation

tszwinglitw
Copy link

Changes

  • added is_critical field in fault_eval_t
  • separate critical from non-critical faults in acc_data_t
  • moved bms fault status to a a standalone can message + can send function

To Do

  • create non-critical faults

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #81

@tszwinglitw tszwinglitw requested a review from jr1221 December 8, 2024 22:42
@tszwinglitw tszwinglitw self-assigned this Dec 8, 2024
@jr1221 jr1221 requested a review from Sabramz December 9, 2024 00:05
jr1221
jr1221 reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for @Sabramz review

Core/Src/stateMachine.c
return fault_status;

// TODO: Remove This !!!! (because this is actually a non-critical fault?)
// fault_status &= ~DISCHARGE_LIMIT_ENFORCEMENT_FAULT;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sabramz hmmm should this be here or not

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know. Something tells me this was a debugging thing done in a rush last year. Lets bring DCL fault back in, and if it gives us problems we can remove it easily.

Sabramz
Sabramz approved these changes Dec 21, 2024
View reviewed changes
Copy link
Contributor

@Sabramz Sabramz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jr1221 jr1221 jr1221 left review comments

@Sabramz Sabramz Sabramz approved these changes

Assignees

@tszwinglitw tszwinglitw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FAULTS] - Implement fault priority & non critical fault capability
3 participants
@tszwinglitw @jr1221 @Sabramz