Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Debug] - Add timer start/stop notices #143

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

[Debug] - Add timer start/stop notices #143

wants to merge 6 commits into from

Conversation

bjackson312006
Copy link

@bjackson312006 bjackson312006 commented Nov 28, 2024 •
edited
Loading

Changes

Added CAN message for timer start/stop notices, sent in the sm_fault_eval function

Checklist

  • All commits are tagged with the ticket number
  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #139

@bjackson312006 bjackson312006 self-assigned this Nov 28, 2024
jr1221
jr1221 reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Obv need to test. See my message on a little quirck with representing fauls.

Core/Src/compute.c Outdated Show resolved Hide resolved
Core/Src/compute.c Outdated Show resolved Hide resolved
jr1221
jr1221 approved these changes Nov 30, 2024
View reviewed changes
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. merge when tested. If you follow this order to merge that would be best, but no biggie if you forget:

  1. -> Merge the embedded-base PR
  2. -> cd into your submodule in this PR, and change it to embedded-base main
  3. -> commit that to this PR^
  4. -> Merge that PR (if it doesnt let you, lmk, it should)

@jr1221 jr1221 requested a review from Sabramz December 13, 2024 18:22
Sabramz
Sabramz approved these changes Dec 21, 2024
View reviewed changes
Copy link
Contributor

@Sabramz Sabramz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good merge after testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sabramz Sabramz Sabramz approved these changes

@jr1221 jr1221 jr1221 approved these changes

Assignees

@bjackson312006 bjackson312006

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Debug] - Add timer start/stop notices
3 participants
@bjackson312006 @jr1221 @Sabramz