Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAULTS] - Implement fault priority & non critical fault capability #81

Open
dyldonahue opened this issue Feb 29, 2024 · 0 comments · May be fixed by #147
Open

[FAULTS] - Implement fault priority & non critical fault capability #81

dyldonahue opened this issue Feb 29, 2024 · 0 comments · May be fixed by #147
Assignees
Labels
enhancement New feature or request

Comments

@dyldonahue
Copy link
Contributor

dyldonahue commented Feb 29, 2024

Current Features

We currently have a set of faults that all (as required by rules) cause the car to turn off with equal authority.

Desired Additional Features

There are some things that can go wrong that aren’t critical, but would be nice to know. Right now, we just dont really track these. We want to add non critical fault capability and perhaps fault tiers, so that we have a framework for tracking other things that go wrong, that we dont want to actually turn the car off.

Ideally, these would exist within the current fault framework, and wed simple add a parameter that defined severity level, with only the highest producing the shutdown behavior we currently have. But, there are different approaches to this architecture, and there may be others that fit well too.

As a sort of “test case” there is currently one error that we catch and do nothing with that fits this bill - CAN errors. In the can handler, you will find a TODO that points to turning this into a non-critical fault. While implementing the faults is mostly out of scope of this ticket, try adding that one as proof of concept

Screenshots (as needed)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants