Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#49: fault dialog #69

Merged
merged 4 commits into from
Feb 16, 2024
Merged

#49: fault dialog #69

merged 4 commits into from
Feb 16, 2024

Conversation

mattrwang
Copy link
Collaborator

Changes

Created a Fault Dialog, modified NonCriticalWarning.qml to display no circle when numWarnings = 0

Screenshots

image

To Do

Any remaining things that need to get done

  • fix NonCritical icon not hiding when category is Critical
  • fix Critical icon not showing up/crashing QT

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #49

@mattrwang mattrwang self-assigned this Feb 13, 2024
Copy link
Collaborator

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont have it be a window and add openModal function like peter has

Copy link
Collaborator

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good enough to merge for now

dimension: 50
numWarnings: 0
Layout.alignment: Qt.AlignHCenter
Layout.topMargin: 60
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont like these rigid margins

@Peyton-McKee Peyton-McKee merged commit a735bf9 into Develop Feb 16, 2024
1 check passed
@Peyton-McKee Peyton-McKee deleted the #49-fault-dialog branch February 16, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QML - Fault Dialog
2 participants