#46-Update-Controller #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a signalsController.cpp and signalsController.h file. The new signalsController class can check and change the status for different signals
Peyton-McKee
requested changes
Jan 25, 2024
I added an AttributeNames header o define possible names for signals as macros. I also added an AttributeStatus header file to define enumeration values for possible statuses. To create a dictionary value for each signal, I created an offViewModel class that assigns a status to a name.
Peyton-McKee
requested changes
Jan 28, 2024
There was a problem hiding this comment.
You should be only making one controller. You need to delete the signals controller if your not using it anymore, also you still need to add pack, motor, state of charge as other q properties. Make sure to tag your commits with the issue number, and also dont make a new model, just ad the function to the current models
Changed attributeStatus enumerations to raw values. Added Q_Properties for pack temp, motor temp, and state of charge
…rn-Electric-Racing/Nero-2.0 into #46-Update-Controller
Update attributeStatus enumerations and add packTemp, stateOfCharge, and motorTemp QProperties to offViewController.
Remove unnecessary efficiencyController.h and chargingController.h imports.
Peyton-McKee
requested changes
Jan 30, 2024
Change packTemp, stateOfCharge, and motorTemp to floats. Introduce a model field for the offViewController class.
Add model import line. Change offViewController constructor to initialize packTemp, motorTemp, and stateOfCharge values. Change updateAttributesFromModel function to properly update attribute statuses.
Peyton-McKee
requested changes
Jan 31, 2024
Connect model in constructor.
…rn-Electric-Racing/Nero-2.0 into #46-Update-Controller
Move attributeNames to data_type_names file.
Delete attributenames.h file.
…rn-Electric-Racing/Nero-2.0 into #46-Update-Controller
Peyton-McKee
requested changes
Jan 31, 2024
Added updates for packTemp, motorTemp, and stateOfCharge to updateAttributesFromModel() function.
Peyton-McKee
requested changes
Feb 1, 2024
| OffViewController::OffViewController(Model *model, QObject *parent) | ||
| : QObject{parent}, m_packTemp(0.0), m_motorTemp(0.0), m_stateOfCharge(0.0) { | ||
| this->m_model = model; | ||
| connect(m_model, &Model::updateAttributesFromModel, this, |
There was a problem hiding this comment.
this compiles? i dont think this function exists in the model, you want the models currentDataDidChange Signal
| @@ -0,0 +1,10 @@ | |||
| #ifndef ATTRIBUTESTATUS_H | |||
There was a problem hiding this comment.
move this file to utils
Move attributeStatus.h to utils folder, update offViewController constructor.
Remove attributeStatus.h from the controllers folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a signalsController.cpp and signalsController.h file. The new signalsController class can check and change the status for different signals
Changes
Added a SignalsController class inside the controllers folder.
Notes
I have not tested the code yet.
Closes #46