Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#14 Convert to cmake #31

Merged
merged 20 commits into from
Oct 25, 2023
Merged

#14 Convert to cmake #31

merged 20 commits into from
Oct 25, 2023

Conversation

Peyton-McKee
Copy link
Collaborator

@Peyton-McKee Peyton-McKee commented Oct 19, 2023 •
edited
Loading

Changes

Converted Code to CMAKE + WIP Spedometer Component

Screenshots

Screenshot 2023-10-19 at 1 39 58 PM Screenshot 2023-10-19 at 1 40 18 PM Screenshot 2023-10-19 at 1 40 32 PM Screenshot 2023-10-19 at 1 40 50 PM Screenshot 2023-10-19 at 1 41 05 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #14 (issue #)

@Peyton-McKee Peyton-McKee self-assigned this Oct 19, 2023
@Peyton-McKee
Copy link
Collaborator Author

Peyton-McKee commented Oct 19, 2023 •
edited
Loading

Updated Screen Shots

Screenshot 2023-10-19 at 5 19 32 PM Screenshot 2023-10-19 at 5 19 39 PM

RChandler234
RChandler234 requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@RChandler234 RChandler234 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is how the spedometer looks on my screen rn (I know that's not how it actually looks but idk how to fix it locally), not sure how I can check out the thermometer as well
image

README.md Outdated Show resolved Hide resolved
NERODesign/content/App.qml Show resolved Hide resolved
NERODesign/content/Spedometer.qml Show resolved Hide resolved
@Peyton-McKee Peyton-McKee merged commit a539afe into main Oct 25, 2023
1 check passed
@Peyton-McKee Peyton-McKee deleted the #14-Spedometer branch October 25, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RChandler234 RChandler234 RChandler234 requested changes

@acd124 acd124 Awaiting requested review from acd124

@tGiech22 tGiech22 Awaiting requested review from tGiech22

Assignees

@Peyton-McKee Peyton-McKee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Home Screen - Spedometer
3 participants
@Peyton-McKee @RChandler234 @tGiech22