Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update thermometer component in QML #123

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

tilakpatell
Copy link
Collaborator

Changes

Changed the thermometer component to resemble a mock and animates based on a value. The thermometer also changes colors based on the temperature value

Screenshots

Screenshot 2024-10-30 at 4 25 19 AM

Closes #113

@tilakpatell tilakpatell requested a review from mattrwang October 30, 2024 21:53
Copy link
Collaborator

@mattrwang mattrwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! instead of having the thermometer change color based on the value, can you add a property that is color and it changes color based on what is passed there?

Copy link
Collaborator

@mattrwang mattrwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mattrwang mattrwang merged commit c4c553c into Develop Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QML] - Update Thermometer Component
2 participants