Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#114: update battery component #119

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

lilyshiomitsu
Copy link
Collaborator

@lilyshiomitsu lilyshiomitsu commented Oct 11, 2024

Changes

changed the battery component to closely match the mock, colors update according to battery percentage, battery % can be changed by updating the battery.value

Screenshots

Screenshot 2024-10-11 at 13 43 55 Screenshot 2024-10-11 at 13 44 26 Screenshot 2024-10-11 at 13 49 56

To Do

possibly make the background transparent but idk

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #114

@lilyshiomitsu lilyshiomitsu self-assigned this Oct 11, 2024
Copy link
Collaborator

@mattrwang mattrwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mattrwang mattrwang merged commit 4ae753f into Develop Oct 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QML] - Update Battery Component
2 participants