Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#112 Animation of Flappy Bird #118

Merged
merged 2 commits into from
Oct 11, 2024
Merged

#112 Animation of Flappy Bird #118

merged 2 commits into from
Oct 11, 2024

Conversation

sumershinde22
Copy link
Collaborator

@sumershinde22 sumershinde22 commented Oct 10, 2024 •
edited
Loading

Changes

  • Made rotation effect when bird jumping or falling
  • Sped up the game every frame
  • Added animations for flapping bird

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #112

@sumershinde22 sumershinde22 self-assigned this Oct 10, 2024
mattrwang
mattrwang requested changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@mattrwang mattrwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dude this looks actually sick, could you make the nosedive delayed slightly to match with how the actual game looks? otherwise it's perfect, good work

mattrwang
mattrwang approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@mattrwang mattrwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattrwang mattrwang merged commit 2301bbc into Develop Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattrwang mattrwang mattrwang approved these changes

Assignees

@sumershinde22 sumershinde22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Games] - Flappy Bird Animation
2 participants
@sumershinde22 @mattrwang