Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IFDEFs and extern all structs #7

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Add IFDEFs and extern all structs #7

merged 3 commits into from
Jun 21, 2024

Conversation

jr1221
Copy link
Contributor

@jr1221 jr1221 commented Jun 21, 2024

Follows new confluence guidelines for extern structs.

Ifdefs everything related to each sensor, kind of overkill but promotes seperation of functionality.

@jr1221 jr1221 marked this pull request as ready for review June 21, 2024 17:43
@jr1221 jr1221 requested a review from dyldonahue June 21, 2024 17:43
Copy link

@dyldonahue dyldonahue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty much good, all extern stuff looked fine really jsut one small preporcessor issue

Core/Inc/can_handler.h Outdated Show resolved Hide resolved
Core/Src/msb.c Show resolved Hide resolved
Core/Src/msb.c Show resolved Hide resolved
@jr1221 jr1221 merged commit 00e6462 into main Jun 21, 2024
2 checks passed
@jr1221 jr1221 deleted the ifdef-and-extern branch June 21, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants