intergated sht #218
Open
intergated sht #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyldonahue
reviewed
Nov 8, 2024
| mpu->temp_sensor->i2c_handle = hi2c; | ||
| assert(!sht30_init(mpu->temp_sensor)); /* This is always connected */ | ||
| assert(!sht30_init(mpu->temp_sensor, temp_write_reg, | ||
| temp_read_reg)); /* This is always connected */ | ||
|
|
||
| assert(!HAL_ADC_Start_DMA(mpu->pedals_adc, mpu->pedal_dma_buf, | ||
| sizeof(mpu->pedal_dma_buf) / |
There was a problem hiding this comment.
this looks good to me. @jr1221 we dont have one of these on mpu right now do we? if not i say we can just merge this one ths embedded base PR looks good. If there is one of these on mpu, lets test before merge
There was a problem hiding this comment.
what kind of testing should I do? I didn't see any test files in caios work, is there a standard for testing in C that NER uses?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added wrappers to integrated agnostic version of sht30
Notes
Should be 100% fine afiak; I looked at all of Ciao's work
Test Cases
To Do
Any remaining things that need to get done
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
Closes # (issue 160)