Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use 'npm prefix' instead 'npm bin' #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seawin
Copy link

@seawin seawin commented Mar 7, 2023

node v18 not support command npm bin, fix with npm prefix.

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2023

CLA assistant check
All committers have signed the CLA.

@ghost
Copy link

ghost commented Oct 18, 2023

Hey @seawin - is this all that is needed to get pc-ble-driver-js working with node version 18? I attempted to pull in your changes (i.e. "pc-ble-driver-js": "NordicSemiconductor/pc-ble-driver-js#pull/289" in my package.json file), but am still running into the following error when npm installing (with node version 18.17.1):

npm ERR! npm ERR! command failed
npm ERR! npm ERR! command sh -c node scripts/pre-install.js && ( (which nrfconnect-build && nrfconnect-build fetch-draft) || node-pre-gyp install --fallback-to-build=false || node build.js )
npm ERR! npm ERR! Validation of nrfjprog libraries failed: Could not locate the bindings file. Tried:
npm ERR! npm ERR! → /Users/USER/.npm/_cacache/tmp/git-cloneqLwjv8/node_modules/pc-nrfjprog-js/build/pc-nrfjprog-js.node
npm ERR! npm ERR! → /Users/USER/.npm/_cacache/tmp/git-cloneqLwjv8/node_modules/pc-nrfjprog-js/build/Debug/pc-nrfjprog-js.node
npm ERR! npm ERR! → /Users/USER/.npm/_cacache/tmp/git-cloneqLwjv8/node_modules/pc-nrfjprog-js/build/Release/pc-nrfjprog-js.node
npm ERR! npm ERR! → /Users/USER/.npm/_cacache/tmp/git-cloneqLwjv8/node_modules/pc-nrfjprog-js/out/Debug/pc-nrfjprog-js.node
npm ERR! npm ERR! → /Users/USER/.npm/_cacache/tmp/git-cloneqLwjv8/node_modules/pc-nrfjprog-js/Debug/pc-nrfjprog-js.node
npm ERR! npm ERR! → /Users/USER/.npm/_cacache/tmp/git-cloneqLwjv8/node_modules/pc-nrfjprog-js/out/Release/pc-nrfjprog-js.node
npm ERR! npm ERR! → /Users/USER/.npm/_cacache/tmp/git-cloneqLwjv8/node_modules/pc-nrfjprog-js/Release/pc-nrfjprog-js.node
npm ERR! npm ERR! → /Users/USER/.npm/_cacache/tmp/git-cloneqLwjv8/node_modules/pc-nrfjprog-js/build/default/pc-nrfjprog-js.node
npm ERR! npm ERR! → /Users/USER/.npm/_cacache/tmp/git-cloneqLwjv8/node_modules/pc-nrfjprog-js/compiled/18.17.1/darwin/arm64/pc-nrfjprog-js.node
npm ERR! npm ERR! → /Users/USER/.npm/_cacache/tmp/git-cloneqLwjv8/node_modules/pc-nrfjprog-js/addon-build/release/install-root/pc-nrfjprog-js.node
npm ERR! npm ERR! → /Users/USER/.npm/_cacache/tmp/git-cloneqLwjv8/node_modules/pc-nrfjprog-js/addon-build/debug/install-root/pc-nrfjprog-js.node
npm ERR! npm ERR! → /Users/USER/.npm/_cacache/tmp/git-cloneqLwjv8/node_modules/pc-nrfjprog-js/addon-build/default/install-root/pc-nrfjprog-js.node
npm ERR! npm ERR! → /Users/USER/.npm/_cacache/tmp/git-cloneqLwjv8/node_modules/pc-nrfjprog-js/lib/binding/node-v108-darwin-arm64/pc-nrfjprog-js.node
npm ERR! npm ERR! Trying to install nrfjprog
npm ERR! npm ERR! Downloading https://github.com/NordicSemiconductor/pc-nrfjprog-js/releases/download/nrfjprog/nrfjprog-10.12.1-darwin_arm64.tar.gz.md5
npm ERR! npm ERR! Error when installing nrfjprog libraries: Request failed with status code 404
npm ERR!
npm ERR! npm ERR! A complete log of this run can be found in: /Users/USER/.npm/_logs/2023-10-18T18_31_37_802Z-debug-0.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants