Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated company_ids.json #132

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Updated company_ids.json #132

merged 1 commit into from
Oct 29, 2024

Conversation

dinesharjani
Copy link
Collaborator

No description provided.

@dinesharjani dinesharjani self-assigned this Oct 28, 2024
@eriklins
Copy link
Contributor

There is an empty entry 3619, which - I think - should be removed. It's also missing in the original BT SiG YAML file: https://bitbucket.org/bluetooth-SIG/public/src/main/assigned_numbers/company_identifiers/company_identifiers.yaml (0x0E23 has not been assigned, not sure why).

@dinesharjani
Copy link
Collaborator Author

There is an empty entry 3619, which - I think - should be removed. It's also missing in the original BT SiG YAML file: https://bitbucket.org/bluetooth-SIG/public/src/main/assigned_numbers/company_identifiers/company_identifiers.yaml (0x0E23 has not been assigned, not sure why).

What a keen eye! I just... yeah, I added it because I don't like the gaps being there. But I guess you're right.

Copy link
Contributor

@eriklins eriklins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now from my perspective.

@dinesharjani
Copy link
Collaborator Author

Hey @eriklins - I'm going to keep 3619 as "Reserved". There's already the precedent of one of these missing IDs to get assigned later. I think it makes sense to keep it. It might never be used, but we can decide later if we keep getting these skips in the Company ID list and modify the scripts to accommodate them.

@eriklins
Copy link
Contributor

Yeah, now as you mention that, I had added this to the Python script I sent to you a while back. It actually inserts a "Reserved" entry on missing entries.

@dinesharjani dinesharjani merged commit 9818da1 into master Oct 29, 2024
7 checks passed
@dinesharjani dinesharjani deleted the update branch October 29, 2024 10:36
@dinesharjani
Copy link
Collaborator Author

Yeah, now as you mention that, I had added this to the Python script I sent to you a while back. It actually inserts a "Reserved" entry on missing entries.

Oh. Okay. Going to look at that now, since I'm here.

@dinesharjani
Copy link
Collaborator Author

Okay, so. I see your script here https://github.com/eriklins/bt-assigned-numbers-to-c-header/blob/main/bt_assigned_numbers_to_c.py

My only issue with it, is that it's Python. Now, I'm not a "web developer". This project is in Node.js because when I built it, the other developers at Nordic that lent me a hand suggested Node.js. Since most of this is node.js, and the Github actions are set up to run node.js, I think the best way to keep this project going forward is to keep it in Node.js / JavaScript. Not sure if I want to tackle writing the whole thing in Javascript now, though I could try feeding it to some ... "artificial intellgence". But I just wanted to come back to you and tell you where my head's at.

@eriklins
Copy link
Contributor

No, this actually is a different script. This one creates C header file from the JSONs here. I sent the one to convert the BT SiG YAML to company_ids.json a while back somewhere here in one of our conversations. Anyway, I arched it again here.

I had never worked with GitHub actions and my experience with JS is quite limited. I used Python for a bunch of scripting stuff and hence used it for the YAML to JSON converter. I'm happy to run this on a regular basis and do a pull request here but I'm not going to port it to Javascript, I'm afraid.

company_ids_to_json.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants