build commands for arm64 #12
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
reinhrst
commented
Jan 8, 2023
| @@ -50,7 +50,7 @@ RUN set -x \ | |||
| # | |||
| && chmod 777 /tmp && apt-get update \ | |||
| && apt-get -y install autoconf \ | |||
| && apt-get -y install --no-install-recommends sudo make g++ g++-multilib \ | |||
| && apt-get -y install --no-install-recommends sudo make g++ gcc-multilib-arm-linux-gnueabi gcc-multilib-arm-linux-gnueabihf \ | |||
There was a problem hiding this comment.
Actually, you probably don't need both, but I didn't spend the time to check which one is needed.
|
@reinhrst Thanks for the contribution. We'll think how to provide builds for arm64 architecture as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes necessary to build the container for arm64. On my M1 Macbook Pro, compiling in the arm64 container is 2.5 times faster than the amd64 one. On other devices (like the RPI4, or linux on an M1 Macbook), arm64 is the only container that will run.
I'm not suggesting pulling in this PR verbatim, but either as a separate branch, or maybe add an extra parameter to the build scripts (I'd be happy to do that if you want) to switch between the architectures (or maybe even have switches in the Dockerfiles themselves for different architectures if this is possible?).
Eventually ideally the pre-built container will be available for arm64 as well.
I just want to make this work available for the next person who needs this.