Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update blom tag to dev1.6.1.10 #608

Closed
wants to merge 1 commit into from
Closed

Update blom tag to dev1.6.1.10 #608

wants to merge 1 commit into from

Conversation

TomasTorsvik
Copy link
Contributor

@TomasTorsvik TomasTorsvik commented Nov 29, 2024 •
edited
Loading

This PR pulls inn the latest updates from blom.

Testing this PR

  • Run test allactive for noresm2_5_alpha08c with the blom tag dev1.6.1.10
  • Run test blom for noresm2_5_alpha08c with the blom tag dev1.6.1.10

@TomasTorsvik TomasTorsvik marked this pull request as draft November 29, 2024 08:32
@TomasTorsvik TomasTorsvik self-assigned this Nov 29, 2024
@TomasTorsvik TomasTorsvik added the Next release Issues needed to be solved before the next release label Nov 29, 2024
@TomasTorsvik TomasTorsvik added this to the NorESM2.5 milestone Nov 29, 2024
@TomasTorsvik TomasTorsvik linked an issue Nov 29, 2024 that may be closed by this pull request
Update noresm_develop with new blom tag dev1.6.1.10 #607
Closed
gold2718
gold2718 requested changes Nov 29, 2024
View reviewed changes
Copy link

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has the wrong commit of BLOM, please update (see my suggestion in #608).

@gold2718
Copy link

I tried to clarify my procedure in #608, please see the update.

@TomasTorsvik
Copy link
Contributor Author

@gold2718 - I have updated the PR following the procedure in #607.

@TomasTorsvik
Copy link
Contributor Author

Test allactive:

  • FAIL on tests NLCOMP, BASELINE, MEMCOMP and TPUTCOMP
    • These fails are probably not severe
  • FAIL at RUN stage for:
    • SMS_D_Ld1.ne30pg3_tn14.N1850.betzy_intel.allactive-defaultio.C.
    • SMS_D_Ld1.ne30pg3_tn14.N1850clmbgc.betzy_intel.allactive-defaultio.C.
    • SMS_D_Ld1.ne30pg3_tn14.N1850fates-sp.betzy_intel.allactive-defaultio.C.
    • SMS_D_Ln9_P256.ne30pg3_ne30pg3_mtn14.F2000climo.betzy_intel.cam-outfrq9s.C.
    • These fails are probably significant

The SMS_D_Ld1.ne30pg3_tn14.N1850* tests all fail with a call to mo_hamocc_step.F90; Line 83, i.e. the call to hamocc4bcm routine.

The SMS_D_Ln9_P256.ne30pg3_ne30pg3_mtn14.F2000climo.betzy_intel.cam-outfrq9s.C fails at the step for writing output file cam.h0a.0001-01-01-00000.nc, apparently due to an error in MPI_Isend.

@jmaerz
Copy link
Contributor

jmaerz commented Nov 29, 2024

Hi @TomasTorsvik , do you know if the failures are due to coupling issues in iHAMOCC or something else?

@TomasTorsvik
Copy link
Contributor Author

@jmaerz - Don't know just yet, the error message was not very descriptive. I'm trying run the same test with an earlier BLOM tag to identify where things start to go wrong.

@TomasTorsvik
Copy link
Contributor Author

TomasTorsvik commented Dec 2, 2024 •
edited
Loading

Testing noresm2_5_alpha08c fails only for the SMS_D_Ln9_P256..ne30pg3_ne30pg3_mtn14.F2000climo.betzy_intel.cam-outfrq9s.C. case. This is built with the BLOM tag dev1.6.1.8. The error is due to MPI_Isend.

Testing noresm2_5_alpha08c with BLOM tag dev1.6.1.9, des not fail for the SMS_D_Ln9_P256..ne30pg3_ne30pg3_mtn14.F2000climo.betzy_intel.cam-outfrq9s.C. case. It would appear that the MPI_Isend error is not persistent.

@TomasTorsvik
Copy link
Contributor Author

@jmaerz - looks like SHELFMASK is causing trouble for the SMS run. Now I see error:

forrtl: severe (408): fort: (8): Attempt to fetch from allocatable variable SHELFMASK when it is not allocated

@TomasTorsvik TomasTorsvik added the wontfix This will not be worked on label Dec 3, 2024
@TomasTorsvik
Copy link
Contributor Author

Due to bug found during testing, I will not merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gold2718 gold2718 gold2718 requested changes

Assignees

@TomasTorsvik TomasTorsvik

Labels
Next release Issues needed to be solved before the next release wontfix This will not be worked on
Projects
NorESM Development
Status: Done
Milestone
NorESM2.5
Development

Successfully merging this pull request may close these issues.

Update noresm_develop with new blom tag dev1.6.1.10
3 participants
@TomasTorsvik @gold2718 @jmaerz