fix(core): remove typo on generating web session signin token #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Hey @ericvilla Don't want to bug you, just would like to do quick poke :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Corrected case sensitivity issue in query parameters for session duration in sign-in token generation.
Bugfixes
Fixed a bug where the session duration parameter was ignored due to a case sensitivity error in the query string. This issue caused Amazon's default session duration of 1 hour to be used regardless of the intended duration.
Enhancements
Enhanced the reliability of session duration handling by fixing the typo in the parameter name from sessionDuration to SessionDuration.
Notes
This fix aligns the parameter casing with Amazon's API requirements, ensuring that session duration settings are correctly applied. This change is crucial for systems that depend on longer session durations for extended operations.