Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dynamic data to useeffect dep array #391

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

esteban-gs
Copy link
Contributor

Dev Summary

This is a simple bugfix for a useEffect without the correct dep array.

This caused the SearchResult component to continously render without end.

Test Plan

repro steps:

  1. localhost:3000
  2. search anything
    expected:

The search no longer loops indefinitely

Resources

@esteban-gs esteban-gs self-assigned this Nov 29, 2023
@denniswangcodes denniswangcodes self-requested a review March 24, 2024 23:48
Copy link
Contributor

@denniswangcodes denniswangcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@denniswangcodes denniswangcodes merged commit 2d311f2 into main Mar 24, 2024
3 checks passed
@denniswangcodes denniswangcodes deleted the fix-run-away-useeffect branch March 24, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants