Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

377/ui categories from db #385

Merged
merged 3 commits into from
Nov 7, 2023
Merged

377/ui categories from db #385

merged 3 commits into from
Nov 7, 2023

Conversation

esteban-gs
Copy link
Contributor

@esteban-gs esteban-gs commented Nov 6, 2023

Dev Summary

  • Delete unused code
  • App settings provider
  • Use SettingsProvider to load categories from backend instead of the hard-coded ones

Test Plan

repro steps:

  1. Start the app and go through the user signup flow
  2. With the browser inspector open, see the network traffic.
  3. Categories should be fetched from the backend when the app first loads.
  4. When you get to the 3rd step in the signup flow, the categories (user interests) should be visible and be the ones that have been seeded into the database

Resources

Devtrium

@esteban-gs esteban-gs self-assigned this Nov 6, 2023
@esteban-gs esteban-gs linked an issue Nov 6, 2023 that may be closed by this pull request
@esteban-gs esteban-gs marked this pull request as ready for review November 6, 2023 02:30
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this data now, being fetched from the backend, this is no longer needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our new implementations of form validation don't used this anymore

@esteban-gs esteban-gs merged commit 1a5830a into main Nov 7, 2023
3 checks passed
@esteban-gs esteban-gs deleted the 377/ui-categories-from-db branch November 7, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Categories list should be sourced from database
1 participant