Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environments behavior #382

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Environments behavior #382

merged 2 commits into from
Oct 27, 2023

Conversation

esteban-gs
Copy link
Contributor

@esteban-gs esteban-gs commented Oct 22, 2023 •
edited
Loading

Dev Summary

This PR makes the email verification requirement only enabled in staging

Test Plan

repro steps:

  1. In local development, signup email verification is not triggered
  2. In staging, it is triggered

Resources

@esteban-gs esteban-gs self-assigned this Oct 22, 2023
@esteban-gs esteban-gs marked this pull request as ready for review October 22, 2023 20:11
@esteban-gs esteban-gs changed the title Environements behavior Environments behavior Oct 22, 2023
@esteban-gs esteban-gs merged commit 25547de into main Oct 27, 2023
3 checks passed
@esteban-gs esteban-gs deleted the dev-environment-emails branch October 27, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@esteban-gs esteban-gs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@esteban-gs