Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show select field error #381

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Show select field error #381

merged 1 commit into from
Oct 20, 2023

Conversation

esteban-gs
Copy link
Contributor

@esteban-gs esteban-gs commented Oct 15, 2023 •
edited
Loading

Dev Summary

This PR adds code to show errors for the select component.

Test Plan

repro steps:

  1. fill out the user sign up form
  2. On the location step, leave state blank
  3. Expect a required error message to show

@esteban-gs esteban-gs self-assigned this Oct 15, 2023
@esteban-gs esteban-gs marked this pull request as ready for review October 15, 2023 04:47
@esteban-gs esteban-gs requested a review from a team October 15, 2023 04:49
@taoliu12
Copy link
Contributor

I checked the website on my local, and it looks good to me.

@esteban-gs esteban-gs merged commit 663e746 into main Oct 20, 2023
3 checks passed
@esteban-gs esteban-gs deleted the 365-select-field-display-error branch October 20, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoliu12 taoliu12 taoliu12 approved these changes

Assignees

@esteban-gs esteban-gs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esteban-gs @taoliu12